| Message ID | 20240511-gemini-ethernet-fix-tso-v2-5-2ed841574624@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ethernet: cortina: TSO and pause param | expand |
On Sat, May 11, 2024 at 12:08:43AM +0200, Linus Walleij wrote: > The Cortina Gemini ethernet can very well set up TX or RX > pausing, so add this functionality to the driver in a > .set_pauseparam() callback. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/net/ethernet/cortina/gemini.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c > index d3134db032a2..137242a4977c 100644 > --- a/drivers/net/ethernet/cortina/gemini.c > +++ b/drivers/net/ethernet/cortina/gemini.c > @@ -2145,6 +2145,17 @@ static void gmac_get_pauseparam(struct net_device *netdev, > pparam->autoneg = true; > } > > +static int gmac_set_pauseparam(struct net_device *netdev, > + struct ethtool_pauseparam *pparam) > +{ > + struct phy_device *phydev = netdev->phydev; > + > + gmac_set_flow_control(netdev, pparam->tx_pause, pparam->rx_pause); > + phy_set_asym_pause(phydev, pparam->rx_pause, pparam->tx_pause); This is a bit of an odd implementation. Normally the value of the pparam.autoneg is used to decide if to directly program the hardware, or to pass it to phylib. Also, the adjust link callback probably should know so that it does not take the autoneg values when auto-neg of pause is disabled. Or, as in your first version, don't allow pparam.autoneg == False. Andrew
diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index d3134db032a2..137242a4977c 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -2145,6 +2145,17 @@ static void gmac_get_pauseparam(struct net_device *netdev, pparam->autoneg = true; } +static int gmac_set_pauseparam(struct net_device *netdev, + struct ethtool_pauseparam *pparam) +{ + struct phy_device *phydev = netdev->phydev; + + gmac_set_flow_control(netdev, pparam->tx_pause, pparam->rx_pause); + phy_set_asym_pause(phydev, pparam->rx_pause, pparam->tx_pause); + + return 0; +} + static void gmac_get_ringparam(struct net_device *netdev, struct ethtool_ringparam *rp, struct kernel_ethtool_ringparam *kernel_rp, @@ -2265,6 +2276,7 @@ static const struct ethtool_ops gmac_351x_ethtool_ops = { .set_link_ksettings = gmac_set_ksettings, .nway_reset = gmac_nway_reset, .get_pauseparam = gmac_get_pauseparam, + .set_pauseparam = gmac_set_pauseparam, .get_ringparam = gmac_get_ringparam, .set_ringparam = gmac_set_ringparam, .get_coalesce = gmac_get_coalesce,
The Cortina Gemini ethernet can very well set up TX or RX pausing, so add this functionality to the driver in a .set_pauseparam() callback. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/net/ethernet/cortina/gemini.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)