| Message ID | 20240513032824.2410459-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ad506586cb69292b6ac59ab95468aadd54b19ab7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dpll: fix return value check for kmemdup | expand |
On 5/13/24 05:28, Chen Ni wrote: > The return value of kmemdup() is dst->freq_supported, not > src->freq_supported. Update the check accordingly. > > Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module") > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/dpll/dpll_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c > index d0f6693ca142..32019dc33cca 100644 > --- a/drivers/dpll/dpll_core.c > +++ b/drivers/dpll/dpll_core.c > @@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct dpll_pin_properties *src, > sizeof(*src->freq_supported); > dst->freq_supported = kmemdup(src->freq_supported, > freq_size, GFP_KERNEL); > - if (!src->freq_supported) > + if (!dst->freq_supported) > return -ENOMEM; > } > if (src->board_label) { Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>From: Chen Ni <nichen@iscas.ac.cn> >Sent: Monday, May 13, 2024 5:28 AM > >The return value of kmemdup() is dst->freq_supported, not >src->freq_supported. Update the check accordingly. > >Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module") >Signed-off-by: Chen Ni <nichen@iscas.ac.cn> >--- > drivers/dpll/dpll_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c >index d0f6693ca142..32019dc33cca 100644 >--- a/drivers/dpll/dpll_core.c >+++ b/drivers/dpll/dpll_core.c >@@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct >dpll_pin_properties *src, > sizeof(*src->freq_supported); > dst->freq_supported = kmemdup(src->freq_supported, > freq_size, GFP_KERNEL); >- if (!src->freq_supported) >+ if (!dst->freq_supported) > return -ENOMEM; > } > if (src->board_label) { >-- >2.25.1 LGTM, Thanks! Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Mon, May 13, 2024 at 05:28:24AM CEST, nichen@iscas.ac.cn wrote: >The return value of kmemdup() is dst->freq_supported, not >src->freq_supported. Update the check accordingly. > >Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module") >Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 13 May 2024 11:28:24 +0800 you wrote: > The return value of kmemdup() is dst->freq_supported, not > src->freq_supported. Update the check accordingly. > > Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module") > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/dpll/dpll_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - dpll: fix return value check for kmemdup https://git.kernel.org/netdev/net/c/ad506586cb69 You are awesome, thank you!
diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c index d0f6693ca142..32019dc33cca 100644 --- a/drivers/dpll/dpll_core.c +++ b/drivers/dpll/dpll_core.c @@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct dpll_pin_properties *src, sizeof(*src->freq_supported); dst->freq_supported = kmemdup(src->freq_supported, freq_size, GFP_KERNEL); - if (!src->freq_supported) + if (!dst->freq_supported) return -ENOMEM; } if (src->board_label) {
The return value of kmemdup() is dst->freq_supported, not src->freq_supported. Update the check accordingly. Fixes: 830ead5fb0c5 ("dpll: fix pin dump crash for rebound module") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/dpll/dpll_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)