| Message ID | 20240515094645.3691877-2-vineeth.karumanchi@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: xilinx_gmii2rgmii: Add clock support. | expand |
On 15/05/2024 11:46, Vineeth Karumanchi wrote: > Add input clock support to gmii_to_rgmii IP. Why? Wasn't it there before? > Add "clocks" and "clock_names" bindings, "clkin" is the input clock name. Please use standard email subjects, so with the PATCH keyword in the title. `git format-patch` helps here to create proper versioned patches. Another useful tool is b4. Skipping the PATCH keyword makes filtering of emails more difficult thus making the review process less convenient. Don't write it by yourself.... Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com> > --- > .../devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml > index 0f781dac6717..d84d13fb2c54 100644 > --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml > +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml > @@ -31,6 +31,13 @@ properties: > phy-handle: > $ref: ethernet-controller.yaml#/properties/phy-handle > > + clocks: > + maxItems: 1 > + > + clock-names: > + const: clkin > + description: 200/375 MHz free-running clock is used as a input clock. Nope, just write the description as items in clocks, instead of maxItems. And drop clock-names, not needed and kind of obvious. Best regards, Krzysztof
Hi Krzysztof, On 15/05/24 7:37 pm, Krzysztof Kozlowski wrote: > On 15/05/2024 11:46, Vineeth Karumanchi wrote: >> Add input clock support to gmii_to_rgmii IP. > > Why? Wasn't it there before? Earlier we used to enable all PL clocks (fixed), now we want to enable only the needed clocks. > >> Add "clocks" and "clock_names" bindings, "clkin" is the input clock name. > > Please use standard email subjects, so with the PATCH keyword in the > title. `git format-patch` helps here to create proper versioned patches. > Another useful tool is b4. Skipping the PATCH keyword makes filtering of > emails more difficult thus making the review process less convenient. > > Don't write it by yourself.... > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > sorry mybad, I used 'git format-patch', but typo!. Will take care from next time. >> >> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com> >> --- >> .../devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml >> index 0f781dac6717..d84d13fb2c54 100644 >> --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml >> +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml >> @@ -31,6 +31,13 @@ properties: >> phy-handle: >> $ref: ethernet-controller.yaml#/properties/phy-handle >> >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + const: clkin >> + description: 200/375 MHz free-running clock is used as a input clock. > > Nope, just write the description as items in clocks, instead of > maxItems. And drop clock-names, not needed and kind of obvious. > OK.
diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml index 0f781dac6717..d84d13fb2c54 100644 --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml @@ -31,6 +31,13 @@ properties: phy-handle: $ref: ethernet-controller.yaml#/properties/phy-handle + clocks: + maxItems: 1 + + clock-names: + const: clkin + description: 200/375 MHz free-running clock is used as a input clock. + required: - compatible - reg @@ -51,5 +58,7 @@ examples: compatible = "xlnx,gmii-to-rgmii-1.0"; reg = <8>; phy-handle = <&phy>; + clocks = <&dummy>; + clock-names = "clkin"; }; };
Add input clock support to gmii_to_rgmii IP. Add "clocks" and "clock_names" bindings, "clkin" is the input clock name. Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com> --- .../devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)