| Message ID | 20240517020609.476882-1-ryasuoka@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work() | expand |
On 17/05/2024 04:06, Ryosuke Yasuoka wrote: > When nci_rx_work() receives a zero-length payload packet, it should not > discard the packet and exit the loop. Instead, it should continue > processing subsequent packets. > > Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") > Reported-by: Ryosuke Yasuoka <ryasuoka@redhat.com> That's not a valid tag here. Every bug we find - like hundreds of my commits - is reported by us... Drop the tag. Best regards, Krzysztof
On Mon, May 20, 2024 at 11:58:47AM +0200, Krzysztof Kozlowski wrote: > On 17/05/2024 04:06, Ryosuke Yasuoka wrote: > > When nci_rx_work() receives a zero-length payload packet, it should not > > discard the packet and exit the loop. Instead, it should continue > > processing subsequent packets. > > > > Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") > > Reported-by: Ryosuke Yasuoka <ryasuoka@redhat.com> > > That's not a valid tag here. Every bug we find - like hundreds of my > commits - is reported by us... > > Drop the tag. > > Best regards, > Krzysztof Thank you for pointing me out, Krzysztof. I didn't understand how to use Reported-by tag correctly. Now I'm clear. Yes, I remove the tag and send a new patch. Very sorry for sending this patch again and again. Ryosuke
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index b133dc55304c..f2ae8b0d81b9 100644 --- a/net/nfc/nci/core.c +++ b/net/nfc/nci/core.c @@ -1518,8 +1518,7 @@ static void nci_rx_work(struct work_struct *work) if (!nci_plen(skb->data)) { kfree_skb(skb); - kcov_remote_stop(); - break; + continue; } /* Process frame */
When nci_rx_work() receives a zero-length payload packet, it should not discard the packet and exit the loop. Instead, it should continue processing subsequent packets. Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") Reported-by: Ryosuke Yasuoka <ryasuoka@redhat.com> Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com> --- v2 - Fix commit msg to be clearer to say - Remove inappropriate Closes tag net/nfc/nci/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)