From patchwork Wed May 29 09:39:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kory Maincent X-Patchwork-Id: 13678564 X-Patchwork-Delegate: kuba@kernel.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A89EB180A88; Wed, 29 May 2024 09:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716975718; cv=none; b=VhHswI2P/wUBJBsM7QVPrDt7ybSryQeOJvBHG0WN2Uz2lS9pYERH/RiuRjb3PysDe5fRBwFeLiad/tY0hGLi8UVAMYQOKhAYf3RM+TGOlZArzxTPQ0CaKDRcVQ5PnnB6nFDFa4El9F0woG3wS134L8fQHgh1fUdCJtKIHeBfZSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716975718; c=relaxed/simple; bh=5SC4SCTap6xR5jJu0SFRaajHz4hnnGaOKkU6KevpGPI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gLkmOqLqje6jKbN2tjpfFwVNxT7rNafWjzQ+BIyQO3qHzOlWH7veYXSxJdAAdbqDbsXf0AAyH36I7zxF2fBQCUiMJA9HPygUoyYTYKm/3EViZQyzbstMp778TmdUHFgItQRN+I2vYWKaD4Kcviz34JTQUyezo61RwFAWGN4XkSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=hxq+Veoz; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="hxq+Veoz" Received: by mail.gandi.net (Postfix) with ESMTPSA id DD83A6000C; Wed, 29 May 2024 09:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1716975715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4D/WDNBi2rRpqkB1dWLbSf8v7lY2RM4BPVKzd1iG1gE=; b=hxq+VeozLmuaIh86nz4WP5beXoHfxwfIHZAHwDKpfeNgLPQVmUJyDqcwj3keyfU5K08zON JvJEqpMB17KqSZqo6FybKSXHepj7pjUaEh8qCwGa3tOxuhAkiBr9Vmqy+twQoCzTzkPNTA J1Yt1OefU99zv7r9/K2Pha1sDNY1fMhhdPlozWbTTPDoFt0I3vZlR6HWcDdXP6RgpMjzfH YFDjytStFxWPeDWtKhyto4J6xDcwoBKLlNoh4bNsgJCuRGkcCLL5FS9M+meolEtBbuoi6J w1tc0gKASP0sopplK2qg/fwrEv9ioW8mkswSgDYGsuN0prsaYlz5LYGqhhKRBQ== From: Kory Maincent Date: Wed, 29 May 2024 11:39:46 +0200 Subject: [PATCH net-next v13 14/14] netlink: specs: tsinfo: Enhance netlink attributes and add a set command Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240529-feature_ptp_netnext-v13-14-6eda4d40fa4f@bootlin.com> References: <20240529-feature_ptp_netnext-v13-0-6eda4d40fa4f@bootlin.com> In-Reply-To: <20240529-feature_ptp_netnext-v13-0-6eda4d40fa4f@bootlin.com> To: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean Cc: Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu , Kory Maincent X-Mailer: b4 0.13.0 X-GND-Sasl: kory.maincent@bootlin.com X-Patchwork-Delegate: kuba@kernel.org Add new attributed to tsinfo allowing to get the tsinfo and the hwtstamp from a phc provider (composed by a phc index and a phc qualifier) on a netdevice's link. Add simultaneously a set command to be able to set hwtstamp configuration for a specified phc provider. Here is few examples: ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --dump tsinfo-get --json '{"header":{"dev-name":"eth0"}}' [{'header': {'dev-index': 3, 'dev-name': 'eth0'}, 'hwtst-provider': {'index': 0, 'qualifier': 0}, 'phc-index': 0, 'rx-filters': {'bits': {'bit': [{'index': 0, 'name': 'none'}, {'index': 2, 'name': 'some'}]}, 'nomask': True, 'size': 16}, 'timestamping': {'bits': {'bit': [{'index': 0, 'name': 'hardware-transmit'}, {'index': 2, 'name': 'hardware-receive'}, {'index': 6, 'name': 'hardware-raw-clock'}]}, 'nomask': True, 'size': 17}, 'tx-types': {'bits': {'bit': [{'index': 0, 'name': 'off'}, {'index': 1, 'name': 'on'}]}, 'nomask': True, 'size': 4}}, {'header': {'dev-index': 3, 'dev-name': 'eth0'}, 'hwtst-provider': {'index': 2, 'qualifier': 0}, 'phc-index': 2, 'rx-filters': {'bits': {'bit': [{'index': 0, 'name': 'none'}, {'index': 1, 'name': 'all'}]}, 'nomask': True, 'size': 16}, 'timestamping': {'bits': {'bit': [{'index': 0, 'name': 'hardware-transmit'}, {'index': 1, 'name': 'software-transmit'}, {'index': 2, 'name': 'hardware-receive'}, {'index': 3, 'name': 'software-receive'}, {'index': 4, 'name': 'software-system-clock'}, {'index': 6, 'name': 'hardware-raw-clock'}]}, 'nomask': True, 'size': 17}, 'tx-types': {'bits': {'bit': [{'index': 0, 'name': 'off'}, {'index': 1, 'name': 'on'}, {'index': 2, 'name': 'onestep-sync'}]}, 'nomask': True, 'size': 4}}] ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do tsinfo-get --json '{"header":{"dev-name":"eth0"}, "hwtst-provider":{"index":0, "qualifier":0 } }' {'header': {'dev-index': 3, 'dev-name': 'eth0'}, 'hwtst-provider': {'index': 0, 'qualifier': 0}, 'phc-index': 0, 'rx-filters': {'bits': {'bit': [{'index': 0, 'name': 'none'}, {'index': 2, 'name': 'some'}]}, 'nomask': True, 'size': 16}, 'timestamping': {'bits': {'bit': [{'index': 0, 'name': 'hardware-transmit'}, {'index': 2, 'name': 'hardware-receive'}, {'index': 6, 'name': 'hardware-raw-clock'}]}, 'nomask': True, 'size': 17}, 'tx-types': {'bits': {'bit': [{'index': 0, 'name': 'off'}, {'index': 1, 'name': 'on'}]}, 'nomask': True, 'size': 4}} ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do tsinfo-set --json '{"header":{"dev-name":"eth0"}, "hwtst-provider":{"index":2, "qualifier":0}}' None ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do tsinfo-get --json '{"header":{"dev-name":"eth0"}, "ghwtstamp":1}' {'header': {'dev-index': 3, 'dev-name': 'eth0'}, 'hwtst-flags': 1, 'rx-filters': {'bits': {'bit': [{'index': 0, 'name': 'none'}]}, 'nomask': True, 'size': 16}, 'tx-types': {'bits': {'bit': [{'index': 0, 'name': 'off'}]}, 'nomask': True, 'size': 4}} ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do tsinfo-set --json '{"header":{"dev-name":"eth0"}, "rx-filters":{"bits": {"bit": {"name":"ptpv2-l4-event"}}, "nomask": 1}, "tx-types":{"bits": {"bit": {"name":"on"}}, "nomask": 1}}' None Signed-off-by: Kory Maincent --- Changes in v8: - New patch Changes in v10: - Add ghwtstamp attributes - Add tsinfo ntf command Changes in v11: - Add examples in the commit message. Changes in v13: - Replace shorter name by real name. - Fix an issue reported by "make -C tools/net/ynl" on the namings. --- Documentation/netlink/specs/ethtool.yaml | 43 +++++++++++++++++++++++++++++++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml index 00dc61358be8..80484908c5ee 100644 --- a/Documentation/netlink/specs/ethtool.yaml +++ b/Documentation/netlink/specs/ethtool.yaml @@ -576,6 +576,15 @@ attribute-sets: - name: tx-err type: uint + - + name: tsinfo-hwtstamp-provider + attributes: + - + name: index + type: u32 + - + name: qualifier + type: u32 - name: tsinfo attributes: @@ -602,6 +611,16 @@ attribute-sets: name: stats type: nest nested-attributes: ts-stat + - + name: ghwtstamp + type: u8 + - + name: hwtstamp-provider + type: nest + nested-attributes: tsinfo-hwtstamp-provider + - + name: hwtstamp-flags + type: u32 - name: cable-result attributes: @@ -1406,7 +1425,7 @@ operations: notify: eee-get - name: tsinfo-get - doc: Get tsinfo params. + doc: Get tsinfo params or hwtstamp config. attribute-set: tsinfo @@ -1414,6 +1433,8 @@ operations: request: attributes: - header + - ghwtstamp + - hwtstamp-provider reply: attributes: - header @@ -1422,6 +1443,8 @@ operations: - rx-filters - phc-index - stats + - hwtstamp-provider + - hwtstamp-flags dump: *tsinfo-get-op - name: cable-test-act @@ -1730,3 +1753,21 @@ operations: name: mm-ntf doc: Notification for change in MAC Merge configuration. notify: mm-get + - + name: tsinfo-set + doc: Set hwtstamp. + + attribute-set: tsinfo + + do: + request: + attributes: + - header + - tx-types + - rx-filters + - hwtstamp-provider + - hwtstamp-flags + - + name: tsinfo-ntf + doc: Notification for change in tsinfo configuration. + notify: tsinfo-get