| Message ID | 20240531111552.3209198-2-leitao@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2b438c5774cc491a4aa8bb1ec4f49c1a0760a173 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] openvswitch: Move stats allocation to core | expand |
Hi, >-----Original Message----- >From: Breno Leitao <leitao@debian.org> >Sent: Friday, May 31, 2024 4:46 PM >To: Pravin B Shelar <pshelar@ovn.org>; David S. Miller <davem@davemloft.net>; >Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo >Abeni <pabeni@redhat.com> >Cc: netdev@vger.kernel.org; horms@kernel.org; open list:OPENVSWITCH ><dev@openvswitch.org>; open list <linux-kernel@vger.kernel.org> >Subject: [EXTERNAL] [PATCH net-next 2/2] openvswitch: Remove generic >.ndo_get_stats64 > >Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is >configured") moved the callback to dev_get_tstats64() to net core, so, >unless the driver is doing some custom stats collection, it does not >need to set .ndo_get_stats64. > >Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it >doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 >function pointer. > >Signed-off-by: Breno Leitao <leitao@debian.org> Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> Thanks, Sundeep >--- > net/openvswitch/vport-internal_dev.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport- >internal_dev.c >index 7daba6ac6912..4b33133cbdff 100644 >--- a/net/openvswitch/vport-internal_dev.c >+++ b/net/openvswitch/vport-internal_dev.c >@@ -85,7 +85,6 @@ static const struct net_device_ops internal_dev_netdev_ops >= { > .ndo_stop = internal_dev_stop, > .ndo_start_xmit = internal_dev_xmit, > .ndo_set_mac_address = eth_mac_addr, >- .ndo_get_stats64 = dev_get_tstats64, > }; > > static struct rtnl_link_ops internal_dev_link_ops __read_mostly = { >-- >2.43.0 >
diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 7daba6ac6912..4b33133cbdff 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/vport-internal_dev.c @@ -85,7 +85,6 @@ static const struct net_device_ops internal_dev_netdev_ops = { .ndo_stop = internal_dev_stop, .ndo_start_xmit = internal_dev_xmit, .ndo_set_mac_address = eth_mac_addr, - .ndo_get_stats64 = dev_get_tstats64, }; static struct rtnl_link_ops internal_dev_link_ops __read_mostly = {
Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Signed-off-by: Breno Leitao <leitao@debian.org> --- net/openvswitch/vport-internal_dev.c | 1 - 1 file changed, 1 deletion(-)