diff mbox series

net: ethtool: remove unused struct 'cable_test_tdr_req_info'

Message ID 20240531233006.302446-1-linux@treblig.org (mailing list archive)
State Accepted
Commit a23b0034e93453cecf435637dfdb14560eeda6c8
Delegated to: Netdev Maintainers
Headers show
Series net: ethtool: remove unused struct 'cable_test_tdr_req_info' | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 904 this patch: 904
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: maxime.chevallier@bootlin.com
netdev/build_clang success Errors and warnings before: 906 this patch: 906
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 908 this patch: 908
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-06-04--18-00 (tests: 1045)

Commit Message

Dr. David Alan Gilbert May 31, 2024, 11:30 p.m. UTC 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

'cable_test_tdr_req_info' is unused since the original
commit f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to
configured").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 net/ethtool/cabletest.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Andrew Lunn June 2, 2024, 5:46 p.m. UTC | #1 
On Sat, Jun 01, 2024 at 12:30:06AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cable_test_tdr_req_info' is unused since the original
> commit f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to
> configured").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
patchwork-bot+netdevbpf@kernel.org June 5, 2024, 9:20 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sat,  1 Jun 2024 00:30:06 +0100 you wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cable_test_tdr_req_info' is unused since the original
> commit f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to
> configured").
> 
> Remove it.
> 
> [...]

Here is the summary with links:
  - net: ethtool: remove unused struct 'cable_test_tdr_req_info'
    https://git.kernel.org/netdev/net-next/c/a23b0034e934

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c
index 06a151165c31..f6f136ec7ddf 100644
--- a/net/ethtool/cabletest.c
+++ b/net/ethtool/cabletest.c
@@ -207,10 +207,6 @@  int ethnl_cable_test_fault_length(struct phy_device *phydev, u8 pair, u32 cm)
 }
 EXPORT_SYMBOL_GPL(ethnl_cable_test_fault_length);
 
-struct cable_test_tdr_req_info {
-	struct ethnl_req_info		base;
-};
-
 static const struct nla_policy cable_test_tdr_act_cfg_policy[] = {
 	[ETHTOOL_A_CABLE_TEST_TDR_CFG_FIRST]	= { .type = NLA_U32 },
 	[ETHTOOL_A_CABLE_TEST_TDR_CFG_LAST]	= { .type = NLA_U32 },