Message ID | 20240531233307.302571-1-linux@treblig.org (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr' | expand |
On Sat, Jun 01, 2024 at 12:33:07AM +0100, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > 'rds_ib_dereg_odp_mr' has been unused since the original > commit 2eafa1746f17 ("net/rds: Handle ODP mr > registration/unregistration"). nit: Maybe commit lines are best not line-wrapped. I'm unsure. > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> The above not withstanding, this looks good to me. Reviewed-by: Simon Horman <horms@kernel.org>
* Simon Horman (horms@kernel.org) wrote: > On Sat, Jun 01, 2024 at 12:33:07AM +0100, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > 'rds_ib_dereg_odp_mr' has been unused since the original > > commit 2eafa1746f17 ("net/rds: Handle ODP mr > > registration/unregistration"). > > nit: Maybe commit lines are best not line-wrapped. > I'm unsure. Yeh I wasn't too sure, checkpatch seems to have code to deal with it, so it is expecting it could be wrapped: # A commit match can span multiple lines so this block attempts to find a # complete typical commit on a maximum of 3 lines > > > > Remove it. > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > The above not withstanding, this looks good to me. > > Reviewed-by: Simon Horman <horms@kernel.org> Thanks! Dave
On Sat, 2024-06-01 at 00:33 +0100, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > 'rds_ib_dereg_odp_mr' has been unused since the original > commit 2eafa1746f17 ("net/rds: Handle ODP mr > registration/unregistration"). > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> This patch looks fine to me, the struct is indeed unused at this point. Thanks for the clean up! Reviewed-by: Allison Henderson <allison.henderson@oracle.com> > --- > net/rds/ib_rdma.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c > index 8f070ee7e742..d1cfceeff133 100644 > --- a/net/rds/ib_rdma.c > +++ b/net/rds/ib_rdma.c > @@ -40,10 +40,6 @@ > #include "rds.h" > > struct workqueue_struct *rds_ib_mr_wq; > -struct rds_ib_dereg_odp_mr { > - struct work_struct work; > - struct ib_mr *mr; > -}; > > static void rds_ib_odp_mr_worker(struct work_struct *work); >
diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index 8f070ee7e742..d1cfceeff133 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -40,10 +40,6 @@ #include "rds.h" struct workqueue_struct *rds_ib_mr_wq; -struct rds_ib_dereg_odp_mr { - struct work_struct work; - struct ib_mr *mr; -}; static void rds_ib_odp_mr_worker(struct work_struct *work);