diff mbox series

[net] ionic: fix kernel panic in XDP_TX action

Message ID 20240603045755.501895-1-ap420073@gmail.com (mailing list archive)
State Accepted
Commit 491aee894a08bc9b8bb52e7363b9d4bc6403f363
Delegated to: Netdev Maintainers
Headers show
Series [net] ionic: fix kernel panic in XDP_TX action | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: bpf@vger.kernel.org
netdev/build_clang success Errors and warnings before: 905 this patch: 905
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 905 this patch: 905
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-06-04--18-00 (tests: 1045)

Commit Message

Taehee Yoo June 3, 2024, 4:57 a.m. UTC 
In the XDP_TX path, ionic driver sends a packet to the TX path with rx
page and corresponding dma address.
After tx is done, ionic_tx_clean() frees that page.
But RX ring buffer isn't reset to NULL.
So, it uses a freed page, which causes kernel panic.

BUG: unable to handle page fault for address: ffff8881576c110c
PGD 773801067 P4D 773801067 PUD 87f086067 PMD 87efca067 PTE 800ffffea893e060
Oops: Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN NOPTI
CPU: 1 PID: 25 Comm: ksoftirqd/1 Not tainted 6.9.0+ #11
Hardware name: ASUS System Product Name/PRIME Z690-P D4, BIOS 0603 11/01/2021
RIP: 0010:bpf_prog_f0b8caeac1068a55_balancer_ingress+0x3b/0x44f
Code: 00 53 41 55 41 56 41 57 b8 01 00 00 00 48 8b 5f 08 4c 8b 77 00 4c 89 f7 48 83 c7 0e 48 39 d8
RSP: 0018:ffff888104e6fa28 EFLAGS: 00010283
RAX: 0000000000000002 RBX: ffff8881576c1140 RCX: 0000000000000002
RDX: ffffffffc0051f64 RSI: ffffc90002d33048 RDI: ffff8881576c110e
RBP: ffff888104e6fa88 R08: 0000000000000000 R09: ffffed1027a04a23
R10: 0000000000000000 R11: 0000000000000000 R12: ffff8881b03a21a8
R13: ffff8881589f800f R14: ffff8881576c1100 R15: 00000001576c1100
FS: 0000000000000000(0000) GS:ffff88881ae00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffff8881576c110c CR3: 0000000767a90000 CR4: 00000000007506f0
PKRU: 55555554
Call Trace:
<TASK>
? __die+0x20/0x70
? page_fault_oops+0x254/0x790
? __pfx_page_fault_oops+0x10/0x10
? __pfx_is_prefetch.constprop.0+0x10/0x10
? search_bpf_extables+0x165/0x260
? fixup_exception+0x4a/0x970
? exc_page_fault+0xcb/0xe0
? asm_exc_page_fault+0x22/0x30
? 0xffffffffc0051f64
? bpf_prog_f0b8caeac1068a55_balancer_ingress+0x3b/0x44f
? do_raw_spin_unlock+0x54/0x220
ionic_rx_service+0x11ab/0x3010 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
? ionic_tx_clean+0x29b/0xc60 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
? __pfx_ionic_tx_clean+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
? __pfx_ionic_rx_service+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
? ionic_tx_cq_service+0x25d/0xa00 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
? __pfx_ionic_rx_service+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
ionic_cq_service+0x69/0x150 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
ionic_txrx_napi+0x11a/0x540 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
__napi_poll.constprop.0+0xa0/0x440
net_rx_action+0x7e7/0xc30
? __pfx_net_rx_action+0x10/0x10

Fixes: 8eeed8373e1c ("ionic: Add XDP_TX support")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
 drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Nelson, Shannon June 3, 2024, 5:32 p.m. UTC | #1 
On 6/2/2024 9:57 PM, Taehee Yoo wrote:
> 
> In the XDP_TX path, ionic driver sends a packet to the TX path with rx
> page and corresponding dma address.
> After tx is done, ionic_tx_clean() frees that page.
> But RX ring buffer isn't reset to NULL.
> So, it uses a freed page, which causes kernel panic.
> 
> BUG: unable to handle page fault for address: ffff8881576c110c
> PGD 773801067 P4D 773801067 PUD 87f086067 PMD 87efca067 PTE 800ffffea893e060
> Oops: Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN NOPTI
> CPU: 1 PID: 25 Comm: ksoftirqd/1 Not tainted 6.9.0+ #11
> Hardware name: ASUS System Product Name/PRIME Z690-P D4, BIOS 0603 11/01/2021
> RIP: 0010:bpf_prog_f0b8caeac1068a55_balancer_ingress+0x3b/0x44f
> Code: 00 53 41 55 41 56 41 57 b8 01 00 00 00 48 8b 5f 08 4c 8b 77 00 4c 89 f7 48 83 c7 0e 48 39 d8
> RSP: 0018:ffff888104e6fa28 EFLAGS: 00010283
> RAX: 0000000000000002 RBX: ffff8881576c1140 RCX: 0000000000000002
> RDX: ffffffffc0051f64 RSI: ffffc90002d33048 RDI: ffff8881576c110e
> RBP: ffff888104e6fa88 R08: 0000000000000000 R09: ffffed1027a04a23
> R10: 0000000000000000 R11: 0000000000000000 R12: ffff8881b03a21a8
> R13: ffff8881589f800f R14: ffff8881576c1100 R15: 00000001576c1100
> FS: 0000000000000000(0000) GS:ffff88881ae00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: ffff8881576c110c CR3: 0000000767a90000 CR4: 00000000007506f0
> PKRU: 55555554
> Call Trace:
> <TASK>
> ? __die+0x20/0x70
> ? page_fault_oops+0x254/0x790
> ? __pfx_page_fault_oops+0x10/0x10
> ? __pfx_is_prefetch.constprop.0+0x10/0x10
> ? search_bpf_extables+0x165/0x260
> ? fixup_exception+0x4a/0x970
> ? exc_page_fault+0xcb/0xe0
> ? asm_exc_page_fault+0x22/0x30
> ? 0xffffffffc0051f64
> ? bpf_prog_f0b8caeac1068a55_balancer_ingress+0x3b/0x44f
> ? do_raw_spin_unlock+0x54/0x220
> ionic_rx_service+0x11ab/0x3010 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? ionic_tx_clean+0x29b/0xc60 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_tx_clean+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_rx_service+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? ionic_tx_cq_service+0x25d/0xa00 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_rx_service+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ionic_cq_service+0x69/0x150 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ionic_txrx_napi+0x11a/0x540 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> __napi_poll.constprop.0+0xa0/0x440
> net_rx_action+0x7e7/0xc30
> ? __pfx_net_rx_action+0x10/0x10
> 
> Fixes: 8eeed8373e1c ("ionic: Add XDP_TX support")
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>

Thanks,
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

> ---
>   drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> index 5dba6d2d633c..2427610f4306 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> @@ -586,6 +586,7 @@ static bool ionic_run_xdp(struct ionic_rx_stats *stats,
>                          netdev_dbg(netdev, "tx ionic_xdp_post_frame err %d\n", err);
>                          goto out_xdp_abort;
>                  }
> +               buf_info->page = NULL;
>                  stats->xdp_tx++;
> 
>                  /* the Tx completion will free the buffers */
> --
> 2.34.1
>
Brett Creeley June 3, 2024, 9:50 p.m. UTC | #2 
On 6/2/2024 9:57 PM, Taehee Yoo wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> In the XDP_TX path, ionic driver sends a packet to the TX path with rx
> page and corresponding dma address.
> After tx is done, ionic_tx_clean() frees that page.
> But RX ring buffer isn't reset to NULL.
> So, it uses a freed page, which causes kernel panic.
> 
> BUG: unable to handle page fault for address: ffff8881576c110c
> PGD 773801067 P4D 773801067 PUD 87f086067 PMD 87efca067 PTE 800ffffea893e060
> Oops: Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN NOPTI
> CPU: 1 PID: 25 Comm: ksoftirqd/1 Not tainted 6.9.0+ #11
> Hardware name: ASUS System Product Name/PRIME Z690-P D4, BIOS 0603 11/01/2021
> RIP: 0010:bpf_prog_f0b8caeac1068a55_balancer_ingress+0x3b/0x44f
> Code: 00 53 41 55 41 56 41 57 b8 01 00 00 00 48 8b 5f 08 4c 8b 77 00 4c 89 f7 48 83 c7 0e 48 39 d8
> RSP: 0018:ffff888104e6fa28 EFLAGS: 00010283
> RAX: 0000000000000002 RBX: ffff8881576c1140 RCX: 0000000000000002
> RDX: ffffffffc0051f64 RSI: ffffc90002d33048 RDI: ffff8881576c110e
> RBP: ffff888104e6fa88 R08: 0000000000000000 R09: ffffed1027a04a23
> R10: 0000000000000000 R11: 0000000000000000 R12: ffff8881b03a21a8
> R13: ffff8881589f800f R14: ffff8881576c1100 R15: 00000001576c1100
> FS: 0000000000000000(0000) GS:ffff88881ae00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: ffff8881576c110c CR3: 0000000767a90000 CR4: 00000000007506f0
> PKRU: 55555554
> Call Trace:
> <TASK>
> ? __die+0x20/0x70
> ? page_fault_oops+0x254/0x790
> ? __pfx_page_fault_oops+0x10/0x10
> ? __pfx_is_prefetch.constprop.0+0x10/0x10
> ? search_bpf_extables+0x165/0x260
> ? fixup_exception+0x4a/0x970
> ? exc_page_fault+0xcb/0xe0
> ? asm_exc_page_fault+0x22/0x30
> ? 0xffffffffc0051f64
> ? bpf_prog_f0b8caeac1068a55_balancer_ingress+0x3b/0x44f
> ? do_raw_spin_unlock+0x54/0x220
> ionic_rx_service+0x11ab/0x3010 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? ionic_tx_clean+0x29b/0xc60 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_tx_clean+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_rx_service+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? ionic_tx_cq_service+0x25d/0xa00 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_rx_service+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ionic_cq_service+0x69/0x150 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ionic_txrx_napi+0x11a/0x540 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> __napi_poll.constprop.0+0xa0/0x440
> net_rx_action+0x7e7/0xc30
> ? __pfx_net_rx_action+0x10/0x10
> 
> Fixes: 8eeed8373e1c ("ionic: Add XDP_TX support")
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
>   drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> index 5dba6d2d633c..2427610f4306 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> @@ -586,6 +586,7 @@ static bool ionic_run_xdp(struct ionic_rx_stats *stats,
>                          netdev_dbg(netdev, "tx ionic_xdp_post_frame err %d\n", err);
>                          goto out_xdp_abort;
>                  }
> +               buf_info->page = NULL;

LGTM. Thanks for the fix.

Reviewed-by: Brett Creeley <brett.creeley@amd.com>

>                  stats->xdp_tx++;
> 
>                  /* the Tx completion will free the buffers */
> --
> 2.34.1
>
patchwork-bot+netdevbpf@kernel.org June 5, 2024, 10 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon,  3 Jun 2024 04:57:55 +0000 you wrote:
> In the XDP_TX path, ionic driver sends a packet to the TX path with rx
> page and corresponding dma address.
> After tx is done, ionic_tx_clean() frees that page.
> But RX ring buffer isn't reset to NULL.
> So, it uses a freed page, which causes kernel panic.
> 
> BUG: unable to handle page fault for address: ffff8881576c110c
> PGD 773801067 P4D 773801067 PUD 87f086067 PMD 87efca067 PTE 800ffffea893e060
> Oops: Oops: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN NOPTI
> CPU: 1 PID: 25 Comm: ksoftirqd/1 Not tainted 6.9.0+ #11
> Hardware name: ASUS System Product Name/PRIME Z690-P D4, BIOS 0603 11/01/2021
> RIP: 0010:bpf_prog_f0b8caeac1068a55_balancer_ingress+0x3b/0x44f
> Code: 00 53 41 55 41 56 41 57 b8 01 00 00 00 48 8b 5f 08 4c 8b 77 00 4c 89 f7 48 83 c7 0e 48 39 d8
> RSP: 0018:ffff888104e6fa28 EFLAGS: 00010283
> RAX: 0000000000000002 RBX: ffff8881576c1140 RCX: 0000000000000002
> RDX: ffffffffc0051f64 RSI: ffffc90002d33048 RDI: ffff8881576c110e
> RBP: ffff888104e6fa88 R08: 0000000000000000 R09: ffffed1027a04a23
> R10: 0000000000000000 R11: 0000000000000000 R12: ffff8881b03a21a8
> R13: ffff8881589f800f R14: ffff8881576c1100 R15: 00000001576c1100
> FS: 0000000000000000(0000) GS:ffff88881ae00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: ffff8881576c110c CR3: 0000000767a90000 CR4: 00000000007506f0
> PKRU: 55555554
> Call Trace:
> <TASK>
> ? __die+0x20/0x70
> ? page_fault_oops+0x254/0x790
> ? __pfx_page_fault_oops+0x10/0x10
> ? __pfx_is_prefetch.constprop.0+0x10/0x10
> ? search_bpf_extables+0x165/0x260
> ? fixup_exception+0x4a/0x970
> ? exc_page_fault+0xcb/0xe0
> ? asm_exc_page_fault+0x22/0x30
> ? 0xffffffffc0051f64
> ? bpf_prog_f0b8caeac1068a55_balancer_ingress+0x3b/0x44f
> ? do_raw_spin_unlock+0x54/0x220
> ionic_rx_service+0x11ab/0x3010 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? ionic_tx_clean+0x29b/0xc60 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_tx_clean+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_rx_service+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? ionic_tx_cq_service+0x25d/0xa00 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ? __pfx_ionic_rx_service+0x10/0x10 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ionic_cq_service+0x69/0x150 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> ionic_txrx_napi+0x11a/0x540 [ionic 9180c3001ab627d82bbc5f3ebe8a0decaf6bb864]
> __napi_poll.constprop.0+0xa0/0x440
> net_rx_action+0x7e7/0xc30
> ? __pfx_net_rx_action+0x10/0x10
> 
> [...]

Here is the summary with links:
  - [net] ionic: fix kernel panic in XDP_TX action
    https://git.kernel.org/netdev/net/c/491aee894a08

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
index 5dba6d2d633c..2427610f4306 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
@@ -586,6 +586,7 @@  static bool ionic_run_xdp(struct ionic_rx_stats *stats,
 			netdev_dbg(netdev, "tx ionic_xdp_post_frame err %d\n", err);
 			goto out_xdp_abort;
 		}
+		buf_info->page = NULL;
 		stats->xdp_tx++;
 
 		/* the Tx completion will free the buffers */