diff mbox series

[net-next,v2,4/8] net: pse-pd: pd692x0: Expand ethtool status message

Message ID 20240607-feature_poe_power_cap-v2-4-c03c2deb83ab@bootlin.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: pse-pd: Add new PSE c33 features | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; GEN HAS DIFF 2 files changed, 95 insertions(+);
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 864 this patch: 864
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 868 this patch: 868
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 868 this patch: 868
netdev/checkpatch warning CHECK: From:/Signed-off-by: email comments mismatch: 'From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>' != 'Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>' WARNING: line length of 93 exceeds 80 columns WARNING: line length of 98 exceeds 80 columns
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Kory Maincent June 7, 2024, 7:30 a.m. UTC 
From: "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com>

This update expands pd692x0_ethtool_get_status() callback with newly
introduced details such as the detected class, current power delivered,
and extended state information.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v2:
- Move in from string status message to c33_pse_ext_state_info.
---
 drivers/net/pse-pd/pd692x0.c | 92 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)
diff mbox series

Patch

diff --git a/drivers/net/pse-pd/pd692x0.c b/drivers/net/pse-pd/pd692x0.c
index 6488b941703c..6b7367d009d6 100644
--- a/drivers/net/pse-pd/pd692x0.c
+++ b/drivers/net/pse-pd/pd692x0.c
@@ -73,6 +73,7 @@  enum {
 	PD692X0_MSG_SET_PORT_PARAM,
 	PD692X0_MSG_GET_PORT_STATUS,
 	PD692X0_MSG_DOWNLOAD_CMD,
+	PD692X0_MSG_GET_PORT_CLASS,
 
 	/* add new message above here */
 	PD692X0_MSG_CNT
@@ -149,6 +150,12 @@  static const struct pd692x0_msg pd692x0_msg_template_list[PD692X0_MSG_CNT] = {
 		.data = {0x16, 0x16, 0x99, 0x4e,
 			 0x4e, 0x4e, 0x4e, 0x4e},
 	},
+	[PD692X0_MSG_GET_PORT_CLASS] = {
+		.key = PD692X0_KEY_REQ,
+		.sub = {0x05, 0xc4},
+		.data = {0x4e, 0x4e, 0x4e, 0x4e,
+			 0x4e, 0x4e, 0x4e, 0x4e},
+	},
 };
 
 static u8 pd692x0_build_msg(struct pd692x0_msg *msg, u8 echo)
@@ -435,6 +442,75 @@  static int pd692x0_pi_is_enabled(struct pse_controller_dev *pcdev, int id)
 	}
 }
 
+struct pd692x0_pse_ext_state_mapping {
+	u32 status_code;
+	enum ethtool_c33_pse_ext_state pse_ext_state;
+	u8 pse_ext_substate;
+};
+
+static const struct pd692x0_pse_ext_state_mapping
+pd692x0_pse_ext_state_map[] = {
+	{0x06, ETHTOOL_C33_PSE_EXT_STATE_VOLTAGE_ISSUE,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_V_OVERVOLTAGE},
+	{0x07, ETHTOOL_C33_PSE_EXT_STATE_VOLTAGE_ISSUE,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_V_UNDERVOLTAGE},
+	{0x08, ETHTOOL_C33_PSE_EXT_STATE_HARDWARE_ISSUE, 0},
+	{0x0C, ETHTOOL_C33_PSE_EXT_STATE_CONFIG,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_CFG_UNDEFINED},
+	{0x11, ETHTOOL_C33_PSE_EXT_STATE_CONFIG,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_CFG_UNDEFINED},
+	{0x12, ETHTOOL_C33_PSE_EXT_STATE_HARDWARE_ISSUE, 0},
+	{0x1B, ETHTOOL_C33_PSE_EXT_STATE_DETECTION,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_DET_IN_PROGRESS},
+	{0x1C, ETHTOOL_C33_PSE_EXT_STATE_DETECTION,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_DET_FAILURE},
+	{0x1E, ETHTOOL_C33_PSE_EXT_STATE_CURRENT_ISSUE,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_CRT_UNDERLOAD},
+	{0x1F, ETHTOOL_C33_PSE_EXT_STATE_CURRENT_ISSUE,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_CRT_OVERLOAD},
+	{0x20, ETHTOOL_C33_PSE_EXT_STATE_POWER_BUDGET_EXCEEDED, 0},
+	{0x21, ETHTOOL_C33_PSE_EXT_STATE_HARDWARE_ISSUE, 0},
+	{0x22, ETHTOOL_C33_PSE_EXT_STATE_CONFIG,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_CFG_CHANGED},
+	{0x24, ETHTOOL_C33_PSE_EXT_STATE_VOLTAGE_ISSUE,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_V_INJECTION},
+	{0x25, ETHTOOL_C33_PSE_EXT_STATE_DETECTION,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_DET_FAILURE},
+	{0x26, ETHTOOL_C33_PSE_EXT_STATE_VOLTAGE_ISSUE, 0},
+	{0x34, ETHTOOL_C33_PSE_EXT_STATE_VOLTAGE_ISSUE,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_V_SHORT_DETECTED},
+	{0x35, ETHTOOL_C33_PSE_EXT_STATE_TEMP_ISSUE, 0},
+	{0x36, ETHTOOL_C33_PSE_EXT_STATE_TEMP_ISSUE, 0},
+	{0x37, ETHTOOL_C33_PSE_EXT_STATE_UNKNOWN, 0},
+	{0x3C, ETHTOOL_C33_PSE_EXT_STATE_POWER_BUDGET_EXCEEDED, 0},
+	{0x3D, ETHTOOL_C33_PSE_EXT_STATE_POWER_BUDGET_EXCEEDED, 0},
+	{0x41, ETHTOOL_C33_PSE_EXT_STATE_POWER_BUDGET_EXCEEDED, 0},
+	{0x43, ETHTOOL_C33_PSE_EXT_STATE_CLASSIFICATION_FAILURE, 0},
+	{0xA0, ETHTOOL_C33_PSE_EXT_STATE_HARDWARE_ISSUE, 0},
+	{0xA7, ETHTOOL_C33_PSE_EXT_STATE_DETECTION,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_DET_FAILURE},
+	{0xA8, ETHTOOL_C33_PSE_EXT_STATE_VOLTAGE_ISSUE,
+		ETHTOOL_C33_PSE_EXT_SUBSTATE_V_OPEN},
+	{ /* sentinel */ }
+};
+
+static void
+pd692x0_get_ext_state(struct ethtool_c33_pse_ext_state_info *c33_ext_state_info,
+		      u32 status_code)
+{
+	const struct pd692x0_pse_ext_state_mapping *ext_state_map;
+
+	ext_state_map = pd692x0_pse_ext_state_map;
+	while (ext_state_map->status_code) {
+		if (ext_state_map->status_code == status_code) {
+			c33_ext_state_info->c33_pse_ext_state = ext_state_map->pse_ext_state;
+			c33_ext_state_info->__c33_pse_ext_substate = ext_state_map->pse_ext_state;
+			return;
+		}
+		ext_state_map++;
+	}
+}
+
 static int pd692x0_ethtool_get_status(struct pse_controller_dev *pcdev,
 				      unsigned long id,
 				      struct netlink_ext_ack *extack,
@@ -442,6 +518,7 @@  static int pd692x0_ethtool_get_status(struct pse_controller_dev *pcdev,
 {
 	struct pd692x0_priv *priv = to_pd692x0_priv(pcdev);
 	struct pd692x0_msg msg, buf = {0};
+	u32 class;
 	int ret;
 
 	ret = pd692x0_fw_unavailable(priv);
@@ -471,6 +548,21 @@  static int pd692x0_ethtool_get_status(struct pse_controller_dev *pcdev,
 
 	priv->admin_state[id] = status->c33_admin_state;
 
+	pd692x0_get_ext_state(&status->c33_ext_state_info, buf.sub[0]);
+
+	status->c33_actual_pw = (buf.data[0] << 4 | buf.data[1]) * 100;
+
+	memset(&buf, 0, sizeof(buf));
+	msg = pd692x0_msg_template_list[PD692X0_MSG_GET_PORT_CLASS];
+	msg.sub[2] = id;
+	ret = pd692x0_sendrecv_msg(priv, &msg, &buf);
+	if (ret < 0)
+		return ret;
+
+	class = buf.data[3] >> 4;
+	if (class <= 8)
+		status->c33_pw_class = class;
+
 	return 0;
 }