| Message ID | 20240617103405.654567-1-jtornosm@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: usb: ax88179_178a: improve link status logs | expand |
On Mon, Jun 17, 2024 at 12:33:59PM +0200, Jose Ignacio Tornos Martinez wrote: > Avoid spurious link status logs that may ultimately be wrong; for example, > if the link is set to down with the cable plugged, then the cable is > unplugged and afer this the link is set to up, the last new log that is nit: after > appearing is incorrectly telling that the link is up. > > In order to aovid errors, show link status logs after link_reset nit: avoid Nits Flagged by checkpatch.pl --codespell > processing, and in order to avoid spurious as much as possible, only show > the link loss when some link status change is detected. > > cc: stable@vger.kernel.org > Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver") > Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> The nits above notwithstanding, this looks good to me. Reviewed-by: Simon Horman <horms@kernel.org> ...
On Mon, Jun 17, 2024 at 12:33:59PM +0200, Jose Ignacio Tornos Martinez wrote: > Avoid spurious link status logs that may ultimately be wrong; for example, > if the link is set to down with the cable plugged, then the cable is > unplugged and afer this the link is set to up, the last new log that is > appearing is incorrectly telling that the link is up. > > In order to aovid errors, show link status logs after link_reset > processing, and in order to avoid spurious as much as possible, only show > the link loss when some link status change is detected. > > cc: stable@vger.kernel.org > Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver") > Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> > --- > drivers/net/usb/ax88179_178a.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c > index c2fb736f78b2..60357796be99 100644 > --- a/drivers/net/usb/ax88179_178a.c > +++ b/drivers/net/usb/ax88179_178a.c > @@ -326,7 +326,8 @@ static void ax88179_status(struct usbnet *dev, struct urb *urb) > > if (netif_carrier_ok(dev->net) != link) { > usbnet_link_change(dev, link, 1); > - netdev_info(dev->net, "ax88179 - Link status is: %d\n", link); > + if (!link) > + netdev_info(dev->net, "ax88179 - Link status is: %d\n", link); Sorry Jose, one more nit I noticed after sending my previous email. The line above looks like it could be wrapped to <= 80 columns wide, which is still preferred for Networking code. Flagged by checkpatch.pl --max-line-length=80 > } > } > ...
Hello Simon, I will fix them right now. Thanks Best regards José Ignacio
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index c2fb736f78b2..60357796be99 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -326,7 +326,8 @@ static void ax88179_status(struct usbnet *dev, struct urb *urb) if (netif_carrier_ok(dev->net) != link) { usbnet_link_change(dev, link, 1); - netdev_info(dev->net, "ax88179 - Link status is: %d\n", link); + if (!link) + netdev_info(dev->net, "ax88179 - Link status is: %d\n", link); } } @@ -1542,6 +1543,7 @@ static int ax88179_link_reset(struct usbnet *dev) GMII_PHY_PHYSR, 2, &tmp16); if (!(tmp16 & GMII_PHY_PHYSR_LINK)) { + netdev_info(dev->net, "ax88179 - Link status is: 0\n"); return 0; } else if (GMII_PHY_PHYSR_GIGA == (tmp16 & GMII_PHY_PHYSR_SMASK)) { mode |= AX_MEDIUM_GIGAMODE | AX_MEDIUM_EN_125MHZ; @@ -1579,6 +1581,8 @@ static int ax88179_link_reset(struct usbnet *dev) netif_carrier_on(dev->net); + netdev_info(dev->net, "ax88179 - Link status is: 1\n"); + return 0; }
Avoid spurious link status logs that may ultimately be wrong; for example, if the link is set to down with the cable plugged, then the cable is unplugged and afer this the link is set to up, the last new log that is appearing is incorrectly telling that the link is up. In order to aovid errors, show link status logs after link_reset processing, and in order to avoid spurious as much as possible, only show the link loss when some link status change is detected. cc: stable@vger.kernel.org Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver") Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> --- drivers/net/usb/ax88179_178a.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)