| Message ID | 20240618025644.25754-3-hengqi@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ethtool: provide the dim profile fine-tuning channel | expand |
On Tue, Jun 18, 2024 at 10:56:41AM +0800, Heng Qi wrote: > DIMLIB's capabilities are supplied by the dim, net_dim, and > rdma_dim objects, and dim's interfaces solely act as a base for > net_dim and rdma_dim and are not explicitly used anywhere else. > rdma_dim is utilized by the infiniband driver, while net_dim > is for network devices, excluding the soc/fsl driver. > > In this patch, net_dim relies on some NET's interfaces, thus > DIMLIB needs to explicitly depend on the NET Kconfig. > > The soc/fsl driver uses the functions provided by net_dim, so > it also needs to depend on NET. > > Signed-off-by: Heng Qi <hengqi@linux.alibaba.com> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig index fcec6ed83d5e..a1e0bc8c1757 100644 --- a/drivers/soc/fsl/Kconfig +++ b/drivers/soc/fsl/Kconfig @@ -22,7 +22,7 @@ config FSL_GUTS config FSL_MC_DPIO tristate "QorIQ DPAA2 DPIO driver" - depends on FSL_MC_BUS + depends on FSL_MC_BUS && NET select SOC_BUS select FSL_GUTS select DIMLIB diff --git a/lib/Kconfig b/lib/Kconfig index d33a268bc256..0ffc4f69564f 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -629,6 +629,7 @@ config SIGNATURE config DIMLIB tristate + depends on NET help Dynamic Interrupt Moderation library. Implements an algorithm for dynamically changing CQ moderation values
DIMLIB's capabilities are supplied by the dim, net_dim, and rdma_dim objects, and dim's interfaces solely act as a base for net_dim and rdma_dim and are not explicitly used anywhere else. rdma_dim is utilized by the infiniband driver, while net_dim is for network devices, excluding the soc/fsl driver. In this patch, net_dim relies on some NET's interfaces, thus DIMLIB needs to explicitly depend on the NET Kconfig. The soc/fsl driver uses the functions provided by net_dim, so it also needs to depend on NET. Signed-off-by: Heng Qi <hengqi@linux.alibaba.com> --- drivers/soc/fsl/Kconfig | 2 +- lib/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)