| Message ID | 20240619150359.311459-4-kamilh@axis.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: bcm5481x: add support for BroadR-Reach mode | expand |
On Wed, Jun 19, 2024 at 05:03:58PM +0200, Kamil Horák - 2N wrote: > There is a group of PHY chips supporting BroadR-Reach link modes in > a manner allowing for more or less identical register usage as standard > Clause 22 PHY. > These chips support standard Ethernet link modes as well, however, the > circuitry is mutually exclusive and cannot be auto-detected. > The link modes in question are 100Base-T1 as defined in IEEE802.3bw, > based on Broadcom's 1BR-100 link mode, and newly defined 10Base-T1BRR > (1BR-10 in Broadcom documents). > > Add optional brr-mode flag to switch the PHY to BroadR-Reach mode. > > Signed-off-by: Kamil Horák - 2N <kamilh@axis.com> Please fix your SoB and from addresses via your gitconfig as I told you to in response to the off-list mail you sent me. You also dropped my Ack without an explanation, why? > --- > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index 8fb2a6ee7e5b..0353ef98f2e1 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -93,6 +93,13 @@ properties: > the turn around line low at end of the control phase of the > MDIO transaction. > > + brr-mode: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Request the PHY to operate in BroadR-Reach mode. This means the > + PHY will use the BroadR-Reach protocol to communicate with the other > + end of the link, including LDS auto-negotiation if applicable. > + > clocks: > maxItems: 1 > description: > -- > 2.39.2 >
On Wed, 19 Jun 2024 18:36:16 +0100 Conor Dooley wrote: > > Signed-off-by: Kamil Horák - 2N <kamilh@axis.com> > > Please fix your SoB and from addresses via your gitconfig as I told you > to in response to the off-list mail you sent me. You also dropped my Ack > without an explanation, why? +1, possibly repeating what Conor already said but the common format if 2N is your employer or sponsor of the work would be: Signed-off-by: Kamil Horák (2N) <kamilh@axis.com>
On Wed, Jun 19, 2024 at 04:38:03PM -0700, Jakub Kicinski wrote: > On Wed, 19 Jun 2024 18:36:16 +0100 Conor Dooley wrote: > > > Signed-off-by: Kamil Horák - 2N <kamilh@axis.com> > > > > Please fix your SoB and from addresses via your gitconfig as I told you > > to in response to the off-list mail you sent me. You also dropped my Ack > > without an explanation, why? > > +1, possibly repeating what Conor already said but the common > format if 2N is your employer or sponsor of the work would be: The explanation I was given was that Axis is the parent company of 2N. > Signed-off-by: Kamil Horák (2N) <kamilh@axis.com> > -- > pw-bot: cr BTW Jakub, am I able to interact with the pw-bot, or is that limited to maintainers/senior netdev reviewers? Been curious about that for a while..
> BTW Jakub, am I able to interact with the pw-bot, or is that limited to > maintainers/senior netdev reviewers? Been curious about that for a > while.. https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#updating-patch-status Andrew
On Thu, 20 Jun 2024 14:59:53 +0200 Andrew Lunn wrote: > > BTW Jakub, am I able to interact with the pw-bot, or is that limited to > > maintainers/senior netdev reviewers? Been curious about that for a > > while.. > > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#updating-patch-status One thing that may not be immediately obvious is that this is our local netdev thing, so it will only work on netdev@ and bpf@. We could try to convince Konstantin to run it for all pw instances, we never tried.
On Thu, Jun 20, 2024 at 06:35:32AM -0700, Jakub Kicinski wrote: > On Thu, 20 Jun 2024 14:59:53 +0200 Andrew Lunn wrote: > > > BTW Jakub, am I able to interact with the pw-bot, or is that limited to > > > maintainers/senior netdev reviewers? Been curious about that for a > > > while.. > > > > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#updating-patch-status Hmm, thanks for the link Andrew. In theory I should be able to use it then, I wonder if it is smart enough to detect that conor@kernel.org is the same person as conor+dt@kernel.org. I'll have to try it at some point and find out :) > > One thing that may not be immediately obvious is that this is our local > netdev thing, so it will only work on netdev@ and bpf@. > We could try to convince Konstantin to run it for all pw instances, we > never tried. ngl, I'd love to have it on the riscv instance. Things are hectic for me this month, but I might just ~harass~ask him about it after that.. Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml index 8fb2a6ee7e5b..0353ef98f2e1 100644 --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml @@ -93,6 +93,13 @@ properties: the turn around line low at end of the control phase of the MDIO transaction. + brr-mode: + $ref: /schemas/types.yaml#/definitions/flag + description: + Request the PHY to operate in BroadR-Reach mode. This means the + PHY will use the BroadR-Reach protocol to communicate with the other + end of the link, including LDS auto-negotiation if applicable. + clocks: maxItems: 1 description:
There is a group of PHY chips supporting BroadR-Reach link modes in a manner allowing for more or less identical register usage as standard Clause 22 PHY. These chips support standard Ethernet link modes as well, however, the circuitry is mutually exclusive and cannot be auto-detected. The link modes in question are 100Base-T1 as defined in IEEE802.3bw, based on Broadcom's 1BR-100 link mode, and newly defined 10Base-T1BRR (1BR-10 in Broadcom documents). Add optional brr-mode flag to switch the PHY to BroadR-Reach mode. Signed-off-by: Kamil Horák - 2N <kamilh@axis.com> --- Documentation/devicetree/bindings/net/ethernet-phy.yaml | 7 +++++++ 1 file changed, 7 insertions(+)