| Message ID | 20240620095751.1911278-1-kory.maincent@bootlin.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7eadf50095bc35c0e17e66cab617a934888edc20 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: pse-pd: Kconfig: Fix missing firmware loader config select | expand |
On Thu, Jun 20, 2024 at 11:57:50AM +0200, Kory Maincent wrote: > Selecting FW_UPLOAD is not sufficient as it allows the firmware loader > API to be built as a module alongside the pd692x0 driver built as builtin. > Add select FW_LOADER to fix this issue. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406200632.hSChnX0g-lkp@intel.com/ > Fixes: 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver") > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 20 Jun 2024 11:57:50 +0200 you wrote: > Selecting FW_UPLOAD is not sufficient as it allows the firmware loader > API to be built as a module alongside the pd692x0 driver built as builtin. > Add select FW_LOADER to fix this issue. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406200632.hSChnX0g-lkp@intel.com/ > Fixes: 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver") > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > [...] Here is the summary with links: - [net] net: pse-pd: Kconfig: Fix missing firmware loader config select https://git.kernel.org/netdev/net/c/7eadf50095bc You are awesome, thank you!
diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig index 577ea904b3d9..7fab916a7f46 100644 --- a/drivers/net/pse-pd/Kconfig +++ b/drivers/net/pse-pd/Kconfig @@ -23,6 +23,7 @@ config PSE_REGULATOR config PSE_PD692X0 tristate "PD692X0 PSE controller" depends on I2C + select FW_LOADER select FW_UPLOAD help This module provides support for PD692x0 regulator based Ethernet
Selecting FW_UPLOAD is not sufficient as it allows the firmware loader API to be built as a module alongside the pd692x0 driver built as builtin. Add select FW_LOADER to fix this issue. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406200632.hSChnX0g-lkp@intel.com/ Fixes: 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver") Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- drivers/net/pse-pd/Kconfig | 1 + 1 file changed, 1 insertion(+)