| Message ID | 20240620133439.102296-1-jtornosm@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 058722ee350c0bdd664e467156feb2bf5d9cc271 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v3] net: usb: ax88179_178a: improve link status logs | expand |
On Thu, Jun 20, 2024 at 03:34:31PM +0200, Jose Ignacio Tornos Martinez wrote: > Avoid spurious link status logs that may ultimately be wrong; for example, > if the link is set to down with the cable plugged, then the cable is > unplugged and after this the link is set to up, the last new log that is > appearing is incorrectly telling that the link is up. > > In order to avoid errors, show link status logs after link_reset > processing, and in order to avoid spurious as much as possible, only show > the link loss when some link status change is detected. > > cc: stable@vger.kernel.org > Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver") > Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 20 Jun 2024 15:34:31 +0200 you wrote: > Avoid spurious link status logs that may ultimately be wrong; for example, > if the link is set to down with the cable plugged, then the cable is > unplugged and after this the link is set to up, the last new log that is > appearing is incorrectly telling that the link is up. > > In order to avoid errors, show link status logs after link_reset > processing, and in order to avoid spurious as much as possible, only show > the link loss when some link status change is detected. > > [...] Here is the summary with links: - [net,v3] net: usb: ax88179_178a: improve link status logs https://git.kernel.org/netdev/net/c/058722ee350c You are awesome, thank you!
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index c2fb736f78b2..b034ef8a73ea 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -326,7 +326,8 @@ static void ax88179_status(struct usbnet *dev, struct urb *urb) if (netif_carrier_ok(dev->net) != link) { usbnet_link_change(dev, link, 1); - netdev_info(dev->net, "ax88179 - Link status is: %d\n", link); + if (!link) + netdev_info(dev->net, "ax88179 - Link status is: 0\n"); } } @@ -1542,6 +1543,7 @@ static int ax88179_link_reset(struct usbnet *dev) GMII_PHY_PHYSR, 2, &tmp16); if (!(tmp16 & GMII_PHY_PHYSR_LINK)) { + netdev_info(dev->net, "ax88179 - Link status is: 0\n"); return 0; } else if (GMII_PHY_PHYSR_GIGA == (tmp16 & GMII_PHY_PHYSR_SMASK)) { mode |= AX_MEDIUM_GIGAMODE | AX_MEDIUM_EN_125MHZ; @@ -1579,6 +1581,8 @@ static int ax88179_link_reset(struct usbnet *dev) netif_carrier_on(dev->net); + netdev_info(dev->net, "ax88179 - Link status is: 1\n"); + return 0; }
Avoid spurious link status logs that may ultimately be wrong; for example, if the link is set to down with the cable plugged, then the cable is unplugged and after this the link is set to up, the last new log that is appearing is incorrectly telling that the link is up. In order to avoid errors, show link status logs after link_reset processing, and in order to avoid spurious as much as possible, only show the link loss when some link status change is detected. cc: stable@vger.kernel.org Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver") Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> --- v3: - Add net as target tree in the subject. - Use constant string instead of variable because no other value is possible. v2: https://lore.kernel.org/netdev/20240618115054.101577-1-jtornosm@redhat.com/ - Fix the nits v1: https://lore.kernel.org/netdev/20240617103405.654567-1-jtornosm@redhat.com/ drivers/net/usb/ax88179_178a.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)