Message ID | 20240621162552.5078-4-yskelg@gmail.com (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net,v2] net/sched: Fixes: 51270d573a8d NULL ptr deref in perf_trace_qdisc_reset() | expand |
On Sat, 22 Jun 2024 01:25:54 +0900 yskelg@gmail.com wrote:
> Subject: [PATCH net v2] net/sched: Fixes: 51270d573a8d NULL ptr deref in perf_trace_qdisc_reset()
the Fixes tag goes before your signoff, rather than as title.
try
git log --grep=Fixes
Hi Jakub, On 6/22/24 9:05 오전, Jakub Kicinski wrote: > On Sat, 22 Jun 2024 01:25:54 +0900 yskelg@gmail.com wrote: >> Subject: [PATCH net v2] net/sched: Fixes: 51270d573a8d NULL ptr deref in perf_trace_qdisc_reset() > > the Fixes tag goes before your signoff, rather than as title. > try > > git log --grep=Fixes Oh, I'm sorry. I completely misunderstood. Thank you for kindly explaining! I'll take your advice and send the next version of the patch! Warm Regards, Yunseong Kim
diff --git a/include/trace/events/qdisc.h b/include/trace/events/qdisc.h index f1b5e816e7e5..170b51fbe47a 100644 --- a/include/trace/events/qdisc.h +++ b/include/trace/events/qdisc.h @@ -81,7 +81,7 @@ TRACE_EVENT(qdisc_reset, TP_ARGS(q), TP_STRUCT__entry( - __string( dev, qdisc_dev(q)->name ) + __string(dev, qdisc_dev(q) ? qdisc_dev(q)->name : "noop_queue") __string( kind, q->ops->id ) __field( u32, parent ) __field( u32, handle )