| Message ID | 20240701064838.425521-2-christophe.roullier@foss.st.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3cd1d4651cebe9776a0142ade36ff9f2e3545436 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fixes for stm32-dwmac driver fails to probe | expand |
On Mon, 2024-07-01 at 08:48 +0200, Christophe Roullier wrote: > When we want to use clock from RCC to clock Ethernet PHY (with ETHCK) > we need to check if value of clock rate is authorized. > If ETHCK is unused, the ETHCK frequency is 0Hz and validation fails. > It makes no sense to validate unused ETHCK, so skip the validation. > > Fixes: 582ac134963e ("net: stmmac: dwmac-stm32: Separate out external clock rate validation") > > Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> Note that you must avoid any empty line in the tag area between the fixes and the SoB tag. I'll exceptionally fix the above while applying the patch, but please run checkpatch before your next submission. Thanks! Paolo
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c index 23cf0a5b047f..d6a268237ca1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c @@ -206,6 +206,9 @@ static int stm32mp1_validate_ethck_rate(struct plat_stmmacenet_data *plat_dat) struct stm32_dwmac *dwmac = plat_dat->bsp_priv; const u32 clk_rate = clk_get_rate(dwmac->clk_eth_ck); + if (!dwmac->enable_eth_ck) + return 0; + switch (plat_dat->mac_interface) { case PHY_INTERFACE_MODE_MII: case PHY_INTERFACE_MODE_GMII:
When we want to use clock from RCC to clock Ethernet PHY (with ETHCK) we need to check if value of clock rate is authorized. If ETHCK is unused, the ETHCK frequency is 0Hz and validation fails. It makes no sense to validate unused ETHCK, so skip the validation. Fixes: 582ac134963e ("net: stmmac: dwmac-stm32: Separate out external clock rate validation") Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> Reviewed-by: Marek Vasut <marex@denx.de> Tested-by: Mark Brown <broonie@kernel.org> --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 3 +++ 1 file changed, 3 insertions(+)