| Message ID | 20240701090746.2171565-5-schalla@marvell.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fixes for CPT and RSS configuration | expand |
On Mon, Jul 1, 2024 at 2:38 PM Srujana Challa <schalla@marvell.com> wrote: > > From: Kiran Kumar K <kirankumark@marvell.com> > > While performing RSS based on IPv6, extension ltype > is not being considered. This will be problem for > fragmented packets or packets with extension header. > Adding changes to match IPv6 ext header along with IPv6 > ltype. > > Fixes: 41a7aa7b800d ("octeontx2-af: NIX Rx flowkey configuration for RSS") > Signed-off-by: Kiran Kumar K <kirankumark@marvell.com> > --- > drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c > index 00af8888e329..bf5c9cc3df87 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c > @@ -3990,7 +3990,7 @@ static int set_flowkey_fields(struct nix_rx_flowkey_alg *alg, u32 flow_cfg) > field->bytesm1 = 15; /* DIP,16 bytes */ > } > } > - field->ltype_mask = 0xF; /* Match only IPv6 */ > + field->ltype_mask = 0xE; /* Match IPv6 and IPv6_ext */ [Kalesh] I would suggest you to have a macro + short comment for the magic number. This magic number is used at multiple places(subsequent patches in this series). > break; > case NIX_FLOW_KEY_TYPE_TCP: > case NIX_FLOW_KEY_TYPE_UDP: > -- > 2.25.1 > >
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c index 00af8888e329..bf5c9cc3df87 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c @@ -3990,7 +3990,7 @@ static int set_flowkey_fields(struct nix_rx_flowkey_alg *alg, u32 flow_cfg) field->bytesm1 = 15; /* DIP,16 bytes */ } } - field->ltype_mask = 0xF; /* Match only IPv6 */ + field->ltype_mask = 0xE; /* Match IPv6 and IPv6_ext */ break; case NIX_FLOW_KEY_TYPE_TCP: case NIX_FLOW_KEY_TYPE_UDP: