| Message ID | 20240701114240.7020-1-liujing@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/ulp: remove unnecessary assignment in tcp_register_ulp | expand |
On Mon, Jul 01, 2024 at 07:42:40PM +0800, Liu Jing wrote: > in the tcp_register_ulp function, the initialized value of 'ret' is unused, > because it will be assigned a value by the -EEXIST.thus remove it. > > Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com> > --- > net/ipv4/tcp_ulp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/tcp_ulp.c b/net/ipv4/tcp_ulp.c > index 2aa442128630..d11bde357e48 100644 > --- a/net/ipv4/tcp_ulp.c > +++ b/net/ipv4/tcp_ulp.c > @@ -58,7 +58,7 @@ static const struct tcp_ulp_ops *__tcp_ulp_find_autoload(const char *name) > */ > int tcp_register_ulp(struct tcp_ulp_ops *ulp) > { > - int ret = 0; > + int ret; > > spin_lock(&tcp_ulp_list_lock); > if (tcp_ulp_find(ulp->name)) > -- > 2.33.0 > > As far as I understand the implementation of 'tcp_register_ulp', the only case when -EEXIST value will be assigned to 'ret' is when 'tcp_ulp_find()' returns true. In all other cases the return value should be zero. According to my understanding, uninitialized return value has been introduced in this patch which is not correct. Thanks, Nacked-by: Michal Kubiak <michal.kubiak@intel.com>
diff --git a/net/ipv4/tcp_ulp.c b/net/ipv4/tcp_ulp.c index 2aa442128630..d11bde357e48 100644 --- a/net/ipv4/tcp_ulp.c +++ b/net/ipv4/tcp_ulp.c @@ -58,7 +58,7 @@ static const struct tcp_ulp_ops *__tcp_ulp_find_autoload(const char *name) */ int tcp_register_ulp(struct tcp_ulp_ops *ulp) { - int ret = 0; + int ret; spin_lock(&tcp_ulp_list_lock); if (tcp_ulp_find(ulp->name))
in the tcp_register_ulp function, the initialized value of 'ret' is unused, because it will be assigned a value by the -EEXIST.thus remove it. Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com> --- net/ipv4/tcp_ulp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)