| Message ID | 20240705095317.12640-1-amishin@t-argos.ru (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] octeontx2-af: Fix incorrect value output on error path in rvu_check_rsrc_availability() | expand |
On Fri, Jul 05, 2024 at 12:53:17PM +0300, Aleksandr Mishin wrote: > In rvu_check_rsrc_availability() in case of invalid SSOW req, an incorrect > data is printed to error log. 'req->sso' value is printed instead of > 'req->ssow'. Looks like "copy-paste" mistake. > > Fix this mistake by replacing 'req->sso' with 'req->ssow'. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 746ea74241fa ("octeontx2-af: Add RVU block LF provisioning support") > Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> Reviewed-by: Simon Horman <horms@kernel.org>
> In rvu_check_rsrc_availability() in case of invalid SSOW req, an incorrect > data is printed to error log. 'req->sso' value is printed instead of … Another wording suggestion: … request, wrong data were logged. … Regards, Markus
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c index ff78251f92d4..5f661e67ccbc 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c @@ -1643,7 +1643,7 @@ static int rvu_check_rsrc_availability(struct rvu *rvu, if (req->ssow > block->lf.max) { dev_err(&rvu->pdev->dev, "Func 0x%x: Invalid SSOW req, %d > max %d\n", - pcifunc, req->sso, block->lf.max); + pcifunc, req->ssow, block->lf.max); return -EINVAL; } mappedlfs = rvu_get_rsrc_mapcount(pfvf, block->addr);
In rvu_check_rsrc_availability() in case of invalid SSOW req, an incorrect data is printed to error log. 'req->sso' value is printed instead of 'req->ssow'. Looks like "copy-paste" mistake. Fix this mistake by replacing 'req->sso' with 'req->ssow'. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 746ea74241fa ("octeontx2-af: Add RVU block LF provisioning support") Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)