| Message ID | 20240708205826.5176-1-olek2@wp.pl (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e1533b6319ab9c3a97dad314dd88b3783bc41b69 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v3] net: ethernet: lantiq_etop: fix double free in detach | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 8 Jul 2024 22:58:26 +0200 you wrote: > The number of the currently released descriptor is never incremented > which results in the same skb being released multiple times. > > Fixes: 504d4721ee8e ("MIPS: Lantiq: Add ethernet driver") > Reported-by: Joe Perches <joe@perches.com> > Closes: https://lore.kernel.org/all/fc1bf93d92bb5b2f99c6c62745507cc22f3a7b2d.camel@perches.com/ > Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > [...] Here is the summary with links: - [net,v3] net: ethernet: lantiq_etop: fix double free in detach https://git.kernel.org/netdev/net/c/e1533b6319ab You are awesome, thank you!
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index 5352fee62d2b..0b9982804370 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -217,9 +217,9 @@ ltq_etop_free_channel(struct net_device *dev, struct ltq_etop_chan *ch) if (ch->dma.irq) free_irq(ch->dma.irq, priv); if (IS_RX(ch->idx)) { - int desc; + struct ltq_dma_channel *dma = &ch->dma; - for (desc = 0; desc < LTQ_DESC_NUM; desc++) + for (dma->desc = 0; dma->desc < LTQ_DESC_NUM; dma->desc++) dev_kfree_skb_any(ch->skb[ch->dma.desc]); } }
The number of the currently released descriptor is never incremented which results in the same skb being released multiple times. Fixes: 504d4721ee8e ("MIPS: Lantiq: Add ethernet driver") Reported-by: Joe Perches <joe@perches.com> Closes: https://lore.kernel.org/all/fc1bf93d92bb5b2f99c6c62745507cc22f3a7b2d.camel@perches.com/ Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/ethernet/lantiq_etop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)