| Message ID | 20240719-beagleplay_fw_upgrade-v1-1-8664d4513252@beagleboard.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add Firmware Upload support for beagleplay cc1352 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Fri, Jul 19, 2024 at 03:15:10PM +0530, Ayush Singh wrote: > boot-gpio (along with reset-gpio) is used to enable bootloader backdoor > for flashing new firmware. > > The pin and pin level to enabel bootloader backdoor is configed using > the following CCFG variables in cc1352p7: > - SET_CCFG_BL_CONFIG_BL_PIN_NO > - SET_CCFG_BL_CONFIG_BL_LEVEL > > Signed-off-by: Ayush Singh <ayush@beagleboard.org> > --- > Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > index 3dde10de4630..a3511bb59b05 100644 > --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > @@ -29,6 +29,9 @@ properties: > reset-gpios: > maxItems: 1 > > + boot-gpios: > + maxItems: 1 I think this needs a description that explains what this is actually for, and "boot-gpios" is not really an accurate name for what it is used for IMO. > + > vdds-supply: true > > required: > @@ -46,6 +49,7 @@ examples: > clocks = <&sclk_hf 0>, <&sclk_lf 25>; > clock-names = "sclk_hf", "sclk_lf"; > reset-gpios = <&pio 35 GPIO_ACTIVE_LOW>; > + boot-gpios = <&pio 36 GPIO_ACTIVE_LOW>; > vdds-supply = <&vdds>; > }; > }; > > -- > 2.45.2 >
On Fri, Jul 19, 2024 at 03:15:10PM +0530, Ayush Singh wrote: > boot-gpio (along with reset-gpio) is used to enable bootloader backdoor > for flashing new firmware. > > The pin and pin level to enabel bootloader backdoor is configed using nit: enable Flagged by checkpatch.pl --codespell > the following CCFG variables in cc1352p7: > - SET_CCFG_BL_CONFIG_BL_PIN_NO > - SET_CCFG_BL_CONFIG_BL_LEVEL > > Signed-off-by: Ayush Singh <ayush@beagleboard.org> > --- > Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > index 3dde10de4630..a3511bb59b05 100644 > --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > @@ -29,6 +29,9 @@ properties: > reset-gpios: > maxItems: 1 > > + boot-gpios: > + maxItems: 1 > + > vdds-supply: true > > required: > @@ -46,6 +49,7 @@ examples: > clocks = <&sclk_hf 0>, <&sclk_lf 25>; > clock-names = "sclk_hf", "sclk_lf"; > reset-gpios = <&pio 35 GPIO_ACTIVE_LOW>; > + boot-gpios = <&pio 36 GPIO_ACTIVE_LOW>; > vdds-supply = <&vdds>; > }; > }; > > -- > 2.45.2 > >
On Sun, Jul 21, 2024 at 10:00:14AM +0100, Simon Horman wrote: > On Fri, Jul 19, 2024 at 03:15:10PM +0530, Ayush Singh wrote: > > boot-gpio (along with reset-gpio) is used to enable bootloader backdoor > > for flashing new firmware. > > > > The pin and pin level to enabel bootloader backdoor is configed using > > nit: enable Sorry, one more: configured > > Flagged by checkpatch.pl --codespell ...
On 7/19/24 20:25, Conor Dooley wrote: > On Fri, Jul 19, 2024 at 03:15:10PM +0530, Ayush Singh wrote: >> boot-gpio (along with reset-gpio) is used to enable bootloader backdoor >> for flashing new firmware. >> >> The pin and pin level to enabel bootloader backdoor is configed using >> the following CCFG variables in cc1352p7: >> - SET_CCFG_BL_CONFIG_BL_PIN_NO >> - SET_CCFG_BL_CONFIG_BL_LEVEL >> >> Signed-off-by: Ayush Singh <ayush@beagleboard.org> >> --- >> Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml >> index 3dde10de4630..a3511bb59b05 100644 >> --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml >> +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml >> @@ -29,6 +29,9 @@ properties: >> reset-gpios: >> maxItems: 1 >> >> + boot-gpios: >> + maxItems: 1 > I think this needs a description that explains what this is actually > for, and "boot-gpios" is not really an accurate name for what it is used > for IMO. I was using the name `boot-gpios` since cc1352-flasher uses the name boot-line. Anyway, would `bsl-gpios` be better? Or for more descriptive names, I guess it can be `bootloader-config-gpios` or `bootloader-backdoor-gpios`. Ayush Singh
On Mon, Jul 22, 2024 at 04:15:41PM +0530, Ayush Singh wrote: > > On 7/19/24 20:25, Conor Dooley wrote: > > On Fri, Jul 19, 2024 at 03:15:10PM +0530, Ayush Singh wrote: > > > boot-gpio (along with reset-gpio) is used to enable bootloader backdoor > > > for flashing new firmware. > > > > > > The pin and pin level to enabel bootloader backdoor is configed using > > > the following CCFG variables in cc1352p7: > > > - SET_CCFG_BL_CONFIG_BL_PIN_NO > > > - SET_CCFG_BL_CONFIG_BL_LEVEL > > > > > > Signed-off-by: Ayush Singh <ayush@beagleboard.org> > > > --- > > > Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > > > index 3dde10de4630..a3511bb59b05 100644 > > > --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > > > +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > > > @@ -29,6 +29,9 @@ properties: > > > reset-gpios: > > > maxItems: 1 > > > + boot-gpios: > > > + maxItems: 1 > > I think this needs a description that explains what this is actually > > for, and "boot-gpios" is not really an accurate name for what it is used > > for IMO. > > I was using the name `boot-gpios` since cc1352-flasher uses the name > boot-line. Anyway, would `bsl-gpios` be better? I dunno, I think that "bsl" is worse. > Or for more descriptive > names, I guess it can be `bootloader-config-gpios` or > `bootloader-backdoor-gpios`. This is the most descriptive and therefore, IMO, best.
diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml index 3dde10de4630..a3511bb59b05 100644 --- a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml @@ -29,6 +29,9 @@ properties: reset-gpios: maxItems: 1 + boot-gpios: + maxItems: 1 + vdds-supply: true required: @@ -46,6 +49,7 @@ examples: clocks = <&sclk_hf 0>, <&sclk_lf 25>; clock-names = "sclk_hf", "sclk_lf"; reset-gpios = <&pio 35 GPIO_ACTIVE_LOW>; + boot-gpios = <&pio 36 GPIO_ACTIVE_LOW>; vdds-supply = <&vdds>; }; };
boot-gpio (along with reset-gpio) is used to enable bootloader backdoor for flashing new firmware. The pin and pin level to enabel bootloader backdoor is configed using the following CCFG variables in cc1352p7: - SET_CCFG_BL_CONFIG_BL_PIN_NO - SET_CCFG_BL_CONFIG_BL_LEVEL Signed-off-by: Ayush Singh <ayush@beagleboard.org> --- Documentation/devicetree/bindings/net/ti,cc1352p7.yaml | 4 ++++ 1 file changed, 4 insertions(+)