| Message ID | 20240726085946.2243526-1-chenridong@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] cgroup/cpuset: reduce redundant comparisons for generating shecd domains | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello. On Fri, Jul 26, 2024 at 08:59:46AM GMT, Chen Ridong <chenridong@huawei.com> wrote: > In the generate_sched_domains function, it's unnecessary to start the > second for loop with zero, which leads redundant comparisons. > Simply start with i+1, as that is sufficient. Please see https://lore.kernel.org/r/20240704062444.262211-1-xavier_qy@163.com Your patch is likely obsoleted with that. Michal
On 2024/7/26 19:37, Michal Koutný wrote: > Hello. > > On Fri, Jul 26, 2024 at 08:59:46AM GMT, Chen Ridong <chenridong@huawei.com> wrote: >> In the generate_sched_domains function, it's unnecessary to start the >> second for loop with zero, which leads redundant comparisons. >> Simply start with i+1, as that is sufficient. > > Please see > https://lore.kernel.org/r/20240704062444.262211-1-xavier_qy@163.com > > Your patch is likely obsoleted with that. > > Michal Thanks, Michal, I'm sorry I didn't notice these patches. It's a good idea to optimize with uf_node. Thanks Ridong
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 40ec4abaf440..1c4c36db3d93 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -1113,7 +1113,7 @@ static int generate_sched_domains(cpumask_var_t **domains, struct cpuset *a = csa[i]; int apn = a->pn; - for (j = 0; j < csn; j++) { + for (j = i + 1; j < csn; j++) { struct cpuset *b = csa[j]; int bpn = b->pn;
In the generate_sched_domains function, it's unnecessary to start the second for loop with zero, which leads redundant comparisons. Simply start with i+1, as that is sufficient. Signed-off-by: Chen Ridong <chenridong@huawei.com> --- kernel/cgroup/cpuset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)