From patchwork Fri Jul 26 19:59:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 13743138 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DB7615099D for ; Fri, 26 Jul 2024 20:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722024011; cv=none; b=B8oJHN7s8sLPTkP1EH/xnxTPK57IVO09W2H1tVP+XD9QIzgrG0l/pbTjHy5nTb/V+3aPseQyETnLr4pzGqtrefDeAo94hsfwWoTmTEGt/3lZg1KQ3T6Fo9Z4so+aW/8hTyZdnyUX/S51QNHetYO/NTgYG36yjVF6QZIkffmY2fM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722024011; c=relaxed/simple; bh=t6EwZ6i4na0n8NMTSrZB1GIshA5X1Zsp8851eUofPjM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RQ6cEUIW2Zgd9r0Ep2Q42uQ07HoVXhwZfEvhKCxtceEwB4Rn5GYIXN5IjaTIyXRSN6SXmiR86ADU5WPU/pjQTpOJ3KcruyGE12wTCKAZhyTv11vL5ysfhFB8CYLx+3KRoTqV/ShV5659fw9w3aIbhzoKTyCDfZZg5gaR6ETKd80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=EDh3v0EF; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="EDh3v0EF" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a7a8e73b29cso167681266b.3 for ; Fri, 26 Jul 2024 13:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1722024007; x=1722628807; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n6vACS09qfMp/6TXOWUchSNtennyGoJCWfR5pa4HeUA=; b=EDh3v0EFWYqQmztkws5YnVxrv1SuxKZ8kmQRNhuc5bTBh/bYHU37tPzY8fKgRtfVyN 2xIylUEHb2cLXibbi1af4e9HjV+A8jnEhnwBXncpSIdYUxnJl5R6d0R/RDpPnKTJoeEX Rd223ZHVWOSba2uKp2XM1rpY4/Ghxp6E/P7t2uQFjwHX/X7JeAznwy4wXkvm7ORml0p9 pCSmBNAx1QoywM+k3EhxU2QAFLVHiU8zkkvcBKkrKZCL4zZQ/crpYlM4RVj/0t8SDADP RXhh2gl+8gpoVAD6qfu2aiGdZ/2DLMRLrWJe6EQKC7otVZ/jWcBcFR10yCCt+SeLp8OP I8IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722024007; x=1722628807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n6vACS09qfMp/6TXOWUchSNtennyGoJCWfR5pa4HeUA=; b=OERvcVwCtuXIOw5aKd95COU1RyzbbBdIgqvtBqsK8nih+I3aTbyLy9UAFdGjJixded YQLnM0ipksuvYv4bpXlT1lHfyUlS4AtkuGFJGmgl8NkkQcXYvhXbB23/f7sm9/QmN4ea 3p+M1i1xv5GUY7fGSuSZxPLqH/ipVar46MT09AvjEJmvae/YGxue+VD3P8WR7QNOFra5 P7ydZnCZZqA/RT3tOinGmuM27JvZ12PEwXPku6r5K/mJnpSmDCF4/sZvnH5QK+PAP1Lg EmNhfZXI9Vx8X3a/384ksssRWV3aX3xFnDt64FpiHbP4bqaxh20Acl2rFA8JsZY6am/E kfHg== X-Forwarded-Encrypted: i=1; AJvYcCXnJnDg1alW2WGSD8irEuA558GCwChDbCaeAwQJCWu20sMfEpzulzhNh1IYGrxln2d+GfyQ/rcDRHMnnN85zPirUoZCGHtK X-Gm-Message-State: AOJu0YzM668+/wysQRmuWJmmCMJbQiud+iwR+hz7b9LyfliwqUSZBoHs HRPRwN3ttSpvw3gAX5YzFE4L1J4Kxpj4Tsc134Hmx75knrrYQ9bt+jUnsrZPjMs= X-Google-Smtp-Source: AGHT+IEvy1txv1WUQfzxlMFCu8wRQC6RbvPsAnRENjxXb+mowGIzRFW6VNoCJbR9EDAeoYQ9pEjbew== X-Received: by 2002:a17:907:7e92:b0:a7d:33f0:4d58 with SMTP id a640c23a62f3a-a7d40128730mr45428566b.48.1722024007043; Fri, 26 Jul 2024 13:00:07 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a245:8609:c1c4:a4f8:94c8:31f2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad90e1esm209999166b.151.2024.07.26.13.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 13:00:06 -0700 (PDT) From: Markus Schneider-Pargmann To: Chandrasekar Ramakrishnan , Marc Kleine-Budde , Vincent Mailhol , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Markus Schneider-Pargmann , =?utf-8?q?Martin_Hundeb=C3=B8?= =?utf-8?q?ll?= , Michal Kubiak , Simon Horman , Tony Lindgren , Judith Mendez Cc: Matthias Schiffer , Linux regression tracking , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] can: m_can: disable_all_interrupts, not clear active_interrupts Date: Fri, 26 Jul 2024 21:59:42 +0200 Message-ID: <20240726195944.2414812-6-msp@baylibre.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240726195944.2414812-1-msp@baylibre.com> References: <20240726195944.2414812-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org active_interrupts is a cache for the enabled interrupts and not the global masking of interrupts. Do not clear this variable otherwise we may loose the state of the interrupts. Fixes: 07f25091ca02 ("can: m_can: Implement receive coalescing") Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index e70c7100a3c9..bf4a9ae76db9 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -483,7 +483,6 @@ static inline void m_can_disable_all_interrupts(struct m_can_classdev *cdev) { m_can_coalescing_disable(cdev); m_can_write(cdev, M_CAN_ILE, 0x0); - cdev->active_interrupts = 0x0; if (!cdev->net->irq) { dev_dbg(cdev->dev, "Stop hrtimer\n");