| Message ID | 20240727001953.13704-1-kuniyu@amazon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9415d375d8520e0ed55f0c0b058928da9a5b5b3d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1,net] rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink(). | expand |
On Fri, 26 Jul 2024 17:19:53 -0700 Kuniyuki Iwashima wrote: > The cited commit accidentally replaced tgt_net with net in rtnl_dellink(). > > As a result, IFLA_TARGET_NETNSID is ignored if the interface is specified > with IFLA_IFNAME or IFLA_ALT_IFNAME. > > Let's pass tgt_net to rtnl_dev_get(). > > Fixes: cc6090e985d7 ("net: rtnetlink: introduce helper to get net_device instance by ifname") > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 26 Jul 2024 17:19:53 -0700 you wrote: > The cited commit accidentally replaced tgt_net with net in rtnl_dellink(). > > As a result, IFLA_TARGET_NETNSID is ignored if the interface is specified > with IFLA_IFNAME or IFLA_ALT_IFNAME. > > Let's pass tgt_net to rtnl_dev_get(). > > [...] Here is the summary with links: - [v1,net] rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink(). https://git.kernel.org/netdev/net/c/9415d375d852 You are awesome, thank you!
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 87e67194f240..73fd7f543fd0 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -3288,7 +3288,7 @@ static int rtnl_dellink(struct sk_buff *skb, struct nlmsghdr *nlh, if (ifm->ifi_index > 0) dev = __dev_get_by_index(tgt_net, ifm->ifi_index); else if (tb[IFLA_IFNAME] || tb[IFLA_ALT_IFNAME]) - dev = rtnl_dev_get(net, tb); + dev = rtnl_dev_get(tgt_net, tb); else if (tb[IFLA_GROUP]) err = rtnl_group_dellink(tgt_net, nla_get_u32(tb[IFLA_GROUP])); else
The cited commit accidentally replaced tgt_net with net in rtnl_dellink(). As a result, IFLA_TARGET_NETNSID is ignored if the interface is specified with IFLA_IFNAME or IFLA_ALT_IFNAME. Let's pass tgt_net to rtnl_dev_get(). Fixes: cc6090e985d7 ("net: rtnetlink: introduce helper to get net_device instance by ifname") Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)