diff mbox series

[v4,1/6] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

Message ID 20240729113226.2905928-2-danishanwar@ti.com (mailing list archive)
State Not Applicable
Headers show
Series Add support for ICSSG PA_STATS | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 7 this patch: 7
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 7 this patch: 7
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 7 this patch: 7
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 26 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest fail net-next-2024-07-30--15-00 (tests: 675)

Commit Message

MD Danish Anwar July 29, 2024, 11:32 a.m. UTC 
Add documentation for pa-stats node which is syscon regmap for
PA_STATS registers. This will be used to dump statistics maintained by
ICSSG firmware.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Roger Quadros Aug. 5, 2024, 6:42 a.m. UTC | #1 
On 29/07/2024 14:32, MD Danish Anwar wrote:
> Add documentation for pa-stats node which is syscon regmap for
> PA_STATS registers. This will be used to dump statistics maintained by
> ICSSG firmware.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: tags should come after Author's Signed-off-by:

> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>
Nishanth Menon Aug. 6, 2024, 3:03 p.m. UTC | #2 
On 09:42-20240805, Roger Quadros wrote:
> 
> 
> On 29/07/2024 14:32, MD Danish Anwar wrote:
> > Add documentation for pa-stats node which is syscon regmap for
> > PA_STATS registers. This will be used to dump statistics maintained by
> > ICSSG firmware.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Reviewed-by: tags should come after Author's Signed-off-by:
> 
> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> 
> Reviewed-by: Roger Quadros <rogerq@kernel.org>

If the net maintainers are OK, they could potentially take the binding
patch along with the driver mods corresponding to this - I am a bit
unsure of picking up a binding if the driver implementation is heading
the wrong way.
MD Danish Anwar Aug. 12, 2024, 5:50 a.m. UTC | #3 
On 06/08/24 8:33 pm, Nishanth Menon wrote:
> On 09:42-20240805, Roger Quadros wrote:
>>
>>
>> On 29/07/2024 14:32, MD Danish Anwar wrote:
>>> Add documentation for pa-stats node which is syscon regmap for
>>> PA_STATS registers. This will be used to dump statistics maintained by
>>> ICSSG firmware.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Reviewed-by: tags should come after Author's Signed-off-by:
>>
>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>
>> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> 
> If the net maintainers are OK, they could potentially take the binding
> patch along with the driver mods corresponding to this - I am a bit
> unsure of picking up a binding if the driver implementation is heading
> the wrong way.
> 

Hi Jakub, Paolo, David, Andrew,

Will it be okay to pick this binding patch to net-next tree. Nishant is
suggesting since the driver changes are done in drivers/net/ the binding
can be picked by net maintainers.

Please let us know if it will be okay to take this binding to net-next.
I can post a new series with just the binding and the driver patch to
net-next if needed.
Jakub Kicinski Aug. 13, 2024, 12:22 a.m. UTC | #4 
On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote:
> > If the net maintainers are OK, they could potentially take the binding
> > patch along with the driver mods corresponding to this - I am a bit
> > unsure of picking up a binding if the driver implementation is heading
> > the wrong way.   
> 
> Hi Jakub, Paolo, David, Andrew,
> 
> Will it be okay to pick this binding patch to net-next tree. Nishant is
> suggesting since the driver changes are done in drivers/net/ the binding
> can be picked by net maintainers.
> 
> Please let us know if it will be okay to take this binding to net-next.
> I can post a new series with just the binding and the driver patch to
> net-next if needed.

Nishanth, could you send an official Ack tag?

No problem with merging it via net-next.
On the code itself you may want to use ethtool_puts().
Nishanth Menon Aug. 13, 2024, 12:44 p.m. UTC | #5 
On 17:22-20240812, Jakub Kicinski wrote:
> On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote:
> > > If the net maintainers are OK, they could potentially take the binding
> > > patch along with the driver mods corresponding to this - I am a bit
> > > unsure of picking up a binding if the driver implementation is heading
> > > the wrong way.   
> > 
> > Hi Jakub, Paolo, David, Andrew,
> > 
> > Will it be okay to pick this binding patch to net-next tree. Nishant is
> > suggesting since the driver changes are done in drivers/net/ the binding
> > can be picked by net maintainers.
> > 
> > Please let us know if it will be okay to take this binding to net-next.
> > I can post a new series with just the binding and the driver patch to
> > net-next if needed.
> 
> Nishanth, could you send an official Ack tag?

Acked-by: Nishanth Menon <nm@ti.com>

Thanks Jakub.

> 
> No problem with merging it via net-next.
> On the code itself you may want to use ethtool_puts().
MD Danish Anwar Aug. 14, 2024, 7:07 a.m. UTC | #6 
On 13/08/24 5:52 am, Jakub Kicinski wrote:
> On Mon, 12 Aug 2024 11:20:56 +0530 MD Danish Anwar wrote:
>>> If the net maintainers are OK, they could potentially take the binding
>>> patch along with the driver mods corresponding to this - I am a bit
>>> unsure of picking up a binding if the driver implementation is heading
>>> the wrong way.   
>>
>> Hi Jakub, Paolo, David, Andrew,
>>
>> Will it be okay to pick this binding patch to net-next tree. Nishant is
>> suggesting since the driver changes are done in drivers/net/ the binding
>> can be picked by net maintainers.
>>
>> Please let us know if it will be okay to take this binding to net-next.
>> I can post a new series with just the binding and the driver patch to
>> net-next if needed.
> 
> Nishanth, could you send an official Ack tag?
> 
> No problem with merging it via net-next.
> On the code itself you may want to use ethtool_puts().

Thanks Jakub, I will send out a new series with just the binding and
driver patch and send it to net-next. I will take care of ethtool_puts().
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
index c402cb2928e8..3cb1471cc6b6 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
@@ -278,6 +278,26 @@  patternProperties:
 
     additionalProperties: false
 
+  ^pa-stats@[a-f0-9]+$:
+    description: |
+      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
+      registers where different statistics related to ICSSG, are dumped by
+      ICSSG firmware. This syscon sub-module will help the device to
+      access/read/write those statistics.
+
+    type: object
+
+    additionalProperties: false
+
+    properties:
+      compatible:
+        items:
+          - const: ti,pruss-pa-st
+          - const: syscon
+
+      reg:
+        maxItems: 1
+
   interrupt-controller@[a-f0-9]+$:
     description: |
       PRUSS INTC Node. Each PRUSS has a single interrupt controller instance