| Message ID | 20240729152651.258713-1-jdamato@fastly.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e832bc9e818ca49078350a89f1de9aceba1775e3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: wangxun: use net_prefetch to simplify logic | expand |
On 29.07.2024 17:26, Joe Damato wrote: > Use net_prefetch to remove #ifdef and simplify prefetch logic. This > follows the pattern introduced in a previous commit f468f21b7af0 ("net: > Take common prefetch code structure into a function"), which replaced > the same logic in all existing drivers at that time. > > Signed-off-by: Joe Damato <jdamato@fastly.com> > --- Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> > drivers/net/ethernet/wangxun/libwx/wx_lib.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c > index 1eecba984f3b..2b3d6586f44a 100644 > --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c > +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c > @@ -251,10 +251,7 @@ static struct sk_buff *wx_build_skb(struct wx_ring *rx_ring, > rx_buffer->page_offset; > > /* prefetch first cache line of first page */ > - prefetch(page_addr); > -#if L1_CACHE_BYTES < 128 > - prefetch(page_addr + L1_CACHE_BYTES); > -#endif > + net_prefetch(page_addr); > > /* allocate a skb to store the frags */ > skb = napi_alloc_skb(&rx_ring->q_vector->napi, WX_RXBUFFER_256);
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 29 Jul 2024 15:26:47 +0000 you wrote: > Use net_prefetch to remove #ifdef and simplify prefetch logic. This > follows the pattern introduced in a previous commit f468f21b7af0 ("net: > Take common prefetch code structure into a function"), which replaced > the same logic in all existing drivers at that time. > > Signed-off-by: Joe Damato <jdamato@fastly.com> > > [...] Here is the summary with links: - [net-next] net: wangxun: use net_prefetch to simplify logic https://git.kernel.org/netdev/net-next/c/e832bc9e818c You are awesome, thank you!
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c index 1eecba984f3b..2b3d6586f44a 100644 --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c @@ -251,10 +251,7 @@ static struct sk_buff *wx_build_skb(struct wx_ring *rx_ring, rx_buffer->page_offset; /* prefetch first cache line of first page */ - prefetch(page_addr); -#if L1_CACHE_BYTES < 128 - prefetch(page_addr + L1_CACHE_BYTES); -#endif + net_prefetch(page_addr); /* allocate a skb to store the frags */ skb = napi_alloc_skb(&rx_ring->q_vector->napi, WX_RXBUFFER_256);
Use net_prefetch to remove #ifdef and simplify prefetch logic. This follows the pattern introduced in a previous commit f468f21b7af0 ("net: Take common prefetch code structure into a function"), which replaced the same logic in all existing drivers at that time. Signed-off-by: Joe Damato <jdamato@fastly.com> --- drivers/net/ethernet/wangxun/libwx/wx_lib.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)