| Message ID | 20240802015924.624368-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] eth: fbnic: select devlink | expand |
On Thu, Aug 01, 2024 at 06:59:24PM -0700, Jakub Kicinski wrote: > Build bot reports undefined references to devlink functions > in fbnic.ko. > > Fixes: 1a9d48892ea5 ("eth: fbnic: Allocate core device specific structures and devlink interface") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202408011219.hiPmwwAs-lkp@intel.com/ > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Thanks, I agree this is needed. Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> But while exercising this I noticed that PAGE_POOL is also needed, which I locally resolved by adding: select PAGE_POOL I can provide a follow-up patch after this one is merged. Or perhaps you can address this in a v2? I have no preference either way.
On Fri, 2 Aug 2024 15:50:38 +0100 Simon Horman wrote: > But while exercising this I noticed that PAGE_POOL is also needed, > which I locally resolved by adding: Oh, good catch. I'm a bit surprised how slow kbuild bot is :( > select PAGE_POOL > > I can provide a follow-up patch after this one is merged. > Or perhaps you can address this in a v2? > I have no preference either way. Please send your version with both selects, I'll mark mine as superseded
On Fri, Aug 02, 2024 at 08:01:48AM -0700, Jakub Kicinski wrote: > On Fri, 2 Aug 2024 15:50:38 +0100 Simon Horman wrote: > > But while exercising this I noticed that PAGE_POOL is also needed, > > which I locally resolved by adding: > > Oh, good catch. I'm a bit surprised how slow kbuild bot is :( > > > select PAGE_POOL > > > > I can provide a follow-up patch after this one is merged. > > Or perhaps you can address this in a v2? > > I have no preference either way. > > Please send your version with both selects, I'll mark mine as superseded Sure. I'll set myself as the author, to save negotiating about that, and as it's only two lines. Do feel free to update as you see fit.
diff --git a/drivers/net/ethernet/meta/Kconfig b/drivers/net/ethernet/meta/Kconfig index c002ede36402..55389f1d22b6 100644 --- a/drivers/net/ethernet/meta/Kconfig +++ b/drivers/net/ethernet/meta/Kconfig @@ -23,6 +23,7 @@ config FBNIC depends on !S390 depends on MAX_SKB_FRAGS < 22 depends on PCI_MSI + select NET_DEVLINK select PHYLINK help This driver supports Meta Platforms Host Network Interface.
Build bot reports undefined references to devlink functions in fbnic.ko. Fixes: 1a9d48892ea5 ("eth: fbnic: Allocate core device specific structures and devlink interface") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202408011219.hiPmwwAs-lkp@intel.com/ Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: alexanderduyck@fb.com --- drivers/net/ethernet/meta/Kconfig | 1 + 1 file changed, 1 insertion(+)