| Message ID | 20240803022949.28229-1-yyyynoom@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: ethernet: remove unnecessary parentheses | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
Hi, this is not how things work. This v2 depends on the previous v1. It shouldn't. v2 should be a standalone patch which includes v1 and all modifications done afterward. When you send a new patch you should: - give an history of changes, below the ---. See [1] - eventually give links to previous version - your new version should not be threaded with the previous mails. It should start a new thread. Le 03/08/2024 à 04:29, Moon Yeounsu a écrit : > remove unnecessary parentheses surrounding `ip_hdrlen()`, > And keep it under 80 columns long to follow the kernel coding style. > > Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com> > --- [1]: here. *As an example*, I would have done as follow, but there is no rule (AFAIK) for this section. Changes in v2: - Remove extra () [Christophe Jaillet, Simon Horman] - Break long lines [Simon Horman] v1: https://lore.kernel.org/all/20240802054421.5428-1-yyyynoom@gmail.com/ > drivers/net/ethernet/jme.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c > index 83b185c995df..d8be0e4dcb07 100644 > --- a/drivers/net/ethernet/jme.c > +++ b/drivers/net/ethernet/jme.c > @@ -947,12 +947,12 @@ jme_udpsum(struct sk_buff *skb) > return csum; > skb_set_network_header(skb, ETH_HLEN); > > - if ((ip_hdr(skb)->protocol != IPPROTO_UDP) || > - (skb->len < (ETH_HLEN + (ip_hdrlen(skb)) + sizeof(struct udphdr)))) { > + if (ip_hdr(skb)->protocol != IPPROTO_UDP || > + skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) { > skb_reset_network_header(skb); > return csum; > } > - skb_set_transport_header(skb, ETH_HLEN + (ip_hdrlen(skb))); > + skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb)); > csum = udp_hdr(skb)->check; > skb_reset_transport_header(skb); > skb_reset_network_header(skb);
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index 83b185c995df..d8be0e4dcb07 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c @@ -947,12 +947,12 @@ jme_udpsum(struct sk_buff *skb) return csum; skb_set_network_header(skb, ETH_HLEN); - if ((ip_hdr(skb)->protocol != IPPROTO_UDP) || - (skb->len < (ETH_HLEN + (ip_hdrlen(skb)) + sizeof(struct udphdr)))) { + if (ip_hdr(skb)->protocol != IPPROTO_UDP || + skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) { skb_reset_network_header(skb); return csum; } - skb_set_transport_header(skb, ETH_HLEN + (ip_hdrlen(skb))); + skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb)); csum = udp_hdr(skb)->check; skb_reset_transport_header(skb); skb_reset_network_header(skb);
remove unnecessary parentheses surrounding `ip_hdrlen()`, And keep it under 80 columns long to follow the kernel coding style. Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com> --- drivers/net/ethernet/jme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)