| Message ID | 20240806-bnx2x-dec-v1-1-ae844ec785e4@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a39036847fa3a0cc09895e1693ef3ab5b74dce1e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] bnx2x: Provide declaration of dmae_reg_go_c in header | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 06 Aug 2024 11:56:01 +0100 you wrote: > Provide declaration of dmae_reg_go_c in header. > This symbol is defined in bnx2x_main.c. > And used in that file and bnx2x_stats.c. > > However, Sparse complains that there is no declaration > of the symbol in dmae_reg_go_c nor is the symbol static. > > [...] Here is the summary with links: - [net-next] bnx2x: Provide declaration of dmae_reg_go_c in header https://git.kernel.org/netdev/net-next/c/a39036847fa3 You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h index 4e9215bce4ad..a018f251d198 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h @@ -868,6 +868,8 @@ #define DORQ_REG_VF_TYPE_VALUE_0 0x170258 #define DORQ_REG_VF_USAGE_CT_LIMIT 0x170340 +extern const u32 dmae_reg_go_c[]; + /* [RW 4] Initial activity counter value on the load request; when the shortcut is done. */ #define DORQ_REG_SHRT_ACT_CNT 0x170070 diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c index 2bb133ae61c3..ba6729f2f9c0 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c @@ -23,8 +23,6 @@ #include "bnx2x_cmn.h" #include "bnx2x_sriov.h" -extern const u32 dmae_reg_go_c[]; - /* Statistics */ /*
Provide declaration of dmae_reg_go_c in header. This symbol is defined in bnx2x_main.c. And used in that file and bnx2x_stats.c. However, Sparse complains that there is no declaration of the symbol in dmae_reg_go_c nor is the symbol static. .../bnx2x_main.c:291:11: warning: symbol 'dmae_reg_go_c' was not declared. Should it be static? Address this by moving the declaration from bnx2x_stats.c to bnx2x_reg.h. No functional change intended. Compile tested only. Signed-off-by: Simon Horman <horms@kernel.org> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h | 2 ++ drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)