| Message ID | 20240807071538.569784-1-guanjun@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/1] net: pse-pd: tps23881: Fix the compiler error about implicit declaration of function ‘FIELD_GET’ | expand |
On Wed, Aug 07, 2024 at 03:15:38PM +0800, 'Guanjun' wrote: > From: Guanjun <guanjun@linux.alibaba.com> > > bitfield.h is not explicitly included but it is required for FIELD_GET. > There will be a compiler error: > drivers/net/pse-pd/tps23881.c: In function ‘tps23881_i2c_probe’: > drivers/net/pse-pd/tps23881.c:755:6: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration] > 755 | if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) { > | ^~~~~~~~~ > cc1: some warnings being treated as errors > > Fixes: 89108cb5c285 (net: pse-pd: tps23881: Fix the device ID check) > Signed-off-by: Guanjun <guanjun@linux.alibaba.com> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you! Regards, Oleksij
On Wed, 7 Aug 2024 15:15:38 +0800 'Guanjun' wrote: > From: Guanjun <guanjun@linux.alibaba.com> > > bitfield.h is not explicitly included but it is required for FIELD_GET. > There will be a compiler error: > drivers/net/pse-pd/tps23881.c: In function ‘tps23881_i2c_probe’: > drivers/net/pse-pd/tps23881.c:755:6: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration] > 755 | if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) { > | ^~~~~~~~~ > cc1: some warnings being treated as errors > > Fixes: 89108cb5c285 (net: pse-pd: tps23881: Fix the device ID check) > Signed-off-by: Guanjun <guanjun@linux.alibaba.com> > --- > drivers/net/pse-pd/tps23881.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/pse-pd/tps23881.c b/drivers/net/pse-pd/tps23881.c > index f90db758554b..fa947e30e2ba 100644 > --- a/drivers/net/pse-pd/tps23881.c > +++ b/drivers/net/pse-pd/tps23881.c > @@ -10,6 +10,7 @@ > #include <linux/i2c.h> > #include <linux/module.h> > #include <linux/of.h> > +#include <linux/bitfield.h> > #include <linux/platform_device.h> > #include <linux/pse-pd/pse.h> > There was another fix posted shortly after which seems better: https://lore.kernel.org/r/20240807075455.2055224-1-arnd@kernel.org/
diff --git a/drivers/net/pse-pd/tps23881.c b/drivers/net/pse-pd/tps23881.c index f90db758554b..fa947e30e2ba 100644 --- a/drivers/net/pse-pd/tps23881.c +++ b/drivers/net/pse-pd/tps23881.c @@ -10,6 +10,7 @@ #include <linux/i2c.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/bitfield.h> #include <linux/platform_device.h> #include <linux/pse-pd/pse.h>