Message ID | 20240809074035.11078-1-r.smirnov@omp.ru (mailing list archive) |
---|---|
State | Awaiting Upstream |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | netfilter: nfnetlink_log: remove unnecessary check in __build_packet_message() | expand |
On 8/9/24 10:40 AM, Roman Smirnov wrote: > skb->dev is always non-NULL, the check is unnecessary. > > Remove it. Mhm, I don't think we need that in a separate paragraph... > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Signed-off-by: Roman Smirnov <r.smirnov@omp.ru> > Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
On Fri, Aug 09, 2024 at 10:40:35AM +0300, Roman Smirnov wrote:
> skb->dev is always non-NULL, the check is unnecessary.
Same check exists in nfnetlink_queue, these two codebases have many
similarities.
I cannot think of any scenario where skb->dev is NULL in any of the
existing hooks.
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 134e05d31061..ee04a52eaf33 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c @@ -566,8 +566,7 @@ __build_packet_message(struct nfnl_log_net *log, nla_put_be32(inst->skb, NFULA_MARK, htonl(skb->mark))) goto nla_put_failure; - if (indev && skb->dev && - skb_mac_header_was_set(skb) && + if (indev && skb_mac_header_was_set(skb) && skb_mac_header_len(skb) != 0) { struct nfulnl_msg_packet_hw phw; int len;