| Message ID | 20240809200654.3503346-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c25504a0ba36968f919aa30caff172ef23346299 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 09/08/2024 22:06, Frank Li wrote: > Add missed property phys, which indicate how connect to serdes phy. > Fix below warning: > arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > index 6538e0ce90b28..25d657be6956f 100644 > --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > @@ -38,6 +38,10 @@ properties: > > managed: true > > + phys: > + description: A reference to the SerDes lane(s) This is not the same phy as phy-handle points to? Best regards, Krzysztof
On Sat, Aug 10, 2024 at 01:46:25PM +0200, Krzysztof Kozlowski wrote: > On 09/08/2024 22:06, Frank Li wrote: > > Add missed property phys, which indicate how connect to serdes phy. > > Fix below warning: > > arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected) > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > > index 6538e0ce90b28..25d657be6956f 100644 > > --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > > +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml > > @@ -38,6 +38,10 @@ properties: > > > > managed: true > > > > + phys: > > + description: A reference to the SerDes lane(s) > > This is not the same phy as phy-handle points to? I go through source code and dts, it is not the same. phys connect to chip internal serdas phys. phy-handle points to external ethernet phy, which is connected by mdio bus generally. Frank > > Best regards, > Krzysztof >
On 09/08/2024 22:06, Frank Li wrote: > Add missed property phys, which indicate how connect to serdes phy. > Fix below warning: > arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 9 Aug 2024 16:06:53 -0400 you wrote: > Add missed property phys, which indicate how connect to serdes phy. > Fix below warning: > arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++ > 1 file changed, 4 insertions(+) Here is the summary with links: - [1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys https://git.kernel.org/netdev/net/c/c25504a0ba36 You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml index 6538e0ce90b28..25d657be6956f 100644 --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml @@ -38,6 +38,10 @@ properties: managed: true + phys: + description: A reference to the SerDes lane(s) + maxItems: 1 + required: - reg
Add missed property phys, which indicate how connect to serdes phy. Fix below warning: arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected) Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++ 1 file changed, 4 insertions(+)