| Message ID | 20240810020632.367019-1-dongml2@chinatelecom.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6b8a024d25ebf7535eb4a3e926309aa693cfe1bd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: vxlan: remove duplicated initialization in vxlan_xmit | expand |
On Sat, Aug 10, 2024 at 10:06:32AM +0800, Menglong Dong wrote: > The variable "did_rsc" is initialized twice, which is unnecessary. Just > remove one of them. > > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn> Thanks, I have verified that did_rsc is initialised to false, else where in this function, before it is otherwise used. And, as the function may return before then, it does seem reasonable to defer initialisation until then. Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Sat, 10 Aug 2024 10:06:32 +0800 you wrote: > The variable "did_rsc" is initialized twice, which is unnecessary. Just > remove one of them. > > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn> > --- > drivers/net/vxlan/vxlan_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: vxlan: remove duplicated initialization in vxlan_xmit https://git.kernel.org/netdev/net-next/c/6b8a024d25eb You are awesome, thank you!
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index fa3c4e08044a..0ddb2eca744d 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -2710,11 +2710,11 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev) struct vxlan_dev *vxlan = netdev_priv(dev); struct vxlan_rdst *rdst, *fdst = NULL; const struct ip_tunnel_info *info; - bool did_rsc = false; struct vxlan_fdb *f; struct ethhdr *eth; __be32 vni = 0; u32 nhid = 0; + bool did_rsc; info = skb_tunnel_info(skb);
The variable "did_rsc" is initialized twice, which is unnecessary. Just remove one of them. Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn> --- drivers/net/vxlan/vxlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)