diff mbox series

[net-next,v5,1/3] ethtool: Add new result codes for TDR diagnostics

Message ID 20240812073046.1728288-1-o.rempel@pengutronix.de (mailing list archive)
State Accepted
Commit 2140e63cd87fa707acf514d594725097bed018fd
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v5,1/3] ethtool: Add new result codes for TDR diagnostics | expand

Checks

Context Check Description
netdev/series_format warning Series does not have a cover letter
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 29 this patch: 29
netdev/build_tools success Errors and warnings before: 9 this patch: 9
netdev/cc_maintainers success CCed 1 of 1 maintainers
netdev/build_clang success Errors and warnings before: 29 this patch: 29
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 34 this patch: 34
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-08-13--12-00 (tests: 706)

Commit Message

Oleksij Rempel Aug. 12, 2024, 7:30 a.m. UTC
Add new result codes to support TDR diagnostics in preparation for
Open Alliance 1000BaseT1 TDR support:

- ETHTOOL_A_CABLE_RESULT_CODE_NOISE: TDR not possible due to high noise
  level.
- ETHTOOL_A_CABLE_RESULT_CODE_RESOLUTION_NOT_POSSIBLE: TDR resolution not
  possible / out of distance.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 include/uapi/linux/ethtool_netlink.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jakub Kicinski Aug. 16, 2024, 5:19 p.m. UTC | #1
On Mon, 12 Aug 2024 09:30:44 +0200 Oleksij Rempel wrote:
> Add new result codes to support TDR diagnostics in preparation for
> Open Alliance 1000BaseT1 TDR support:
> 
> - ETHTOOL_A_CABLE_RESULT_CODE_NOISE: TDR not possible due to high noise
>   level.
> - ETHTOOL_A_CABLE_RESULT_CODE_RESOLUTION_NOT_POSSIBLE: TDR resolution not
>   possible / out of distance.

Oleksij, please improve your postings. You have no cover letter here.
No link to previous postings. You didn't take Andrew's review tags 
from v4.
patchwork-bot+netdevbpf@kernel.org Aug. 16, 2024, 5:20 p.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 12 Aug 2024 09:30:44 +0200 you wrote:
> Add new result codes to support TDR diagnostics in preparation for
> Open Alliance 1000BaseT1 TDR support:
> 
> - ETHTOOL_A_CABLE_RESULT_CODE_NOISE: TDR not possible due to high noise
>   level.
> - ETHTOOL_A_CABLE_RESULT_CODE_RESOLUTION_NOT_POSSIBLE: TDR resolution not
>   possible / out of distance.
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/3] ethtool: Add new result codes for TDR diagnostics
    https://git.kernel.org/netdev/net-next/c/2140e63cd87f
  - [net-next,v5,2/3] phy: Add Open Alliance helpers for the PHY framework
    https://git.kernel.org/netdev/net-next/c/9e7c1a9b9033
  - [net-next,v5,3/3] net: phy: dp83tg720: Add cable testing support
    https://git.kernel.org/netdev/net-next/c/20f77dc72471

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/uapi/linux/ethtool_netlink.h b/include/uapi/linux/ethtool_netlink.h
index 6d5bdcc67631a..fc814c8a5ac47 100644
--- a/include/uapi/linux/ethtool_netlink.h
+++ b/include/uapi/linux/ethtool_netlink.h
@@ -556,6 +556,10 @@  enum {
 	 * a regular 100 Ohm cable and a part with the abnormal impedance value
 	 */
 	ETHTOOL_A_CABLE_RESULT_CODE_IMPEDANCE_MISMATCH,
+	/* TDR not possible due to high noise level */
+	ETHTOOL_A_CABLE_RESULT_CODE_NOISE,
+	/* TDR resolution not possible / out of distance */
+	ETHTOOL_A_CABLE_RESULT_CODE_RESOLUTION_NOT_POSSIBLE,
 };
 
 enum {