diff mbox series

[net,3/4] MAINTAINERS: Add header files to NETWORKING sections

Message ID 20240816-net-mnt-v1-3-ef946b47ced4@kernel.org (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series MAINTAINERS: Networking updates | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net, async
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success No Fixes tags, but series doesn't touch code
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 7 this patch: 7
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 7 this patch: 7
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 7 this patch: 7
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 50 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Simon Horman Aug. 16, 2024, 12:38 p.m. UTC
This is part of an effort to assign a section in MAINTAINERS to header
files that relate to Networking. In this case the files with "net" or
"skbuff" in their name.

This patch adds a number of such files to the NETWORKING DRIVERS
and NETWORKING [GENERAL] sections.

Signed-off-by: Simon Horman <horms@kernel.org>
---
 MAINTAINERS | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Simon Horman Aug. 16, 2024, 1:25 p.m. UTC | #1
On Fri, Aug 16, 2024 at 01:38:02PM +0100, Simon Horman wrote:
> This is part of an effort to assign a section in MAINTAINERS to header
> files that relate to Networking. In this case the files with "net" or
> "skbuff" in their name.
> 
> This patch adds a number of such files to the NETWORKING DRIVERS
> and NETWORKING [GENERAL] sections.
> 
> Signed-off-by: Simon Horman <horms@kernel.org>

...

> @@ -15939,14 +15944,31 @@ F:	include/linux/framer/framer-provider.h
>  F:	include/linux/framer/framer.h
>  F:	include/linux/in.h
>  F:	include/linux/indirect_call_wrapper.h
> +F:	include/linux/inet.h
> +F:	include/linux/inet_diag.h
>  F:	include/linux/net.h
> +F:	include/linux/netdev_features.h
>  F:	include/linux/netdevice.h
> +F:	include/linux/netlink.h
> +F:	include/linux/netpoll.h
> +F:	include/linux/rtnetlink.h
> +F:	include/linux/seq_file_net.h
>  F:	include/linux/skbuff.h
> +F:	include/linux/skbuff_ref.h
>  F:	include/net/
> +F:	include/uapi/linux/genetlink.h
> +F:	include/uapi/linux/hsr_netlink.h
>  F:	include/uapi/linux/in.h
> +F:	include/uapi/linux/inet_diag.h
> +F:	include/uapi/linux/nbd-netlink.h
>  F:	include/uapi/linux/net.h
>  F:	include/uapi/linux/net_namespace.h
> +F:	include/uapi/linux/net_shaper.h

Sorry, net_shaper.h doesn't exist upstream, but must have in my local
tree when I prepared this. I'll send a v2 in due course.

...
Jakub Kicinski Aug. 16, 2024, 3:38 p.m. UTC | #2
On Fri, 16 Aug 2024 14:25:35 +0100 Simon Horman wrote:
> Sorry, net_shaper.h doesn't exist upstream, but must have in my local
> tree when I prepared this. I'll send a v2 in due course.

Any thoughts on using regexps more?

Like for instance:

include/uapi/linux/net_*

should cover existing missing cases, and net_shaper when it comes.

include/linux/netdev*

could be anther from the context of the quote.
Simon Horman Aug. 16, 2024, 4:57 p.m. UTC | #3
On Fri, Aug 16, 2024 at 08:38:58AM -0700, Jakub Kicinski wrote:
> On Fri, 16 Aug 2024 14:25:35 +0100 Simon Horman wrote:
> > Sorry, net_shaper.h doesn't exist upstream, but must have in my local
> > tree when I prepared this. I'll send a v2 in due course.
> 
> Any thoughts on using regexps more?
> 
> Like for instance:
> 
> include/uapi/linux/net_*
> 
> should cover existing missing cases, and net_shaper when it comes.
> 
> include/linux/netdev*
> 
> could be anther from the context of the quote.

Sure, let me try and verify that we don't get any unintended consequences,
e.g. via false positives. If not I'll update the patch accordingly.

I agree that it would be good to catch things that don't exist yet.
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 28a67b93cef1..38f3731d0e3b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15879,14 +15879,19 @@  F:	drivers/net/
 F:	include/dt-bindings/net/
 F:	include/linux/cn_proc.h
 F:	include/linux/etherdevice.h
+F:	include/linux/ethtool_netlink.h
 F:	include/linux/fcdevice.h
 F:	include/linux/fddidevice.h
 F:	include/linux/hippidevice.h
 F:	include/linux/if_*
 F:	include/linux/inetdevice.h
 F:	include/linux/netdevice.h
+F:	include/linux/netdevice_xmit.h
+F:	include/linux/platform_data/wiznet.h
 F:	include/uapi/linux/cn_proc.h
+F:	include/uapi/linux/ethtool_netlink.h
 F:	include/uapi/linux/if_*
+F:	include/uapi/linux/netdev.h
 F:	include/uapi/linux/netdevice.h
 F:	tools/testing/selftests/drivers/net/
 X:	drivers/net/wireless/
@@ -15939,14 +15944,31 @@  F:	include/linux/framer/framer-provider.h
 F:	include/linux/framer/framer.h
 F:	include/linux/in.h
 F:	include/linux/indirect_call_wrapper.h
+F:	include/linux/inet.h
+F:	include/linux/inet_diag.h
 F:	include/linux/net.h
+F:	include/linux/netdev_features.h
 F:	include/linux/netdevice.h
+F:	include/linux/netlink.h
+F:	include/linux/netpoll.h
+F:	include/linux/rtnetlink.h
+F:	include/linux/seq_file_net.h
 F:	include/linux/skbuff.h
+F:	include/linux/skbuff_ref.h
 F:	include/net/
+F:	include/uapi/linux/genetlink.h
+F:	include/uapi/linux/hsr_netlink.h
 F:	include/uapi/linux/in.h
+F:	include/uapi/linux/inet_diag.h
+F:	include/uapi/linux/nbd-netlink.h
 F:	include/uapi/linux/net.h
 F:	include/uapi/linux/net_namespace.h
+F:	include/uapi/linux/net_shaper.h
+F:	include/uapi/linux/netconf.h
 F:	include/uapi/linux/netdevice.h
+F:	include/uapi/linux/netlink.h
+F:	include/uapi/linux/netlink_diag.h
+F:	include/uapi/linux/rtnetlink.h
 F:	lib/net_utils.c
 F:	lib/random32.c
 F:	net/