diff mbox series

[net-next] gve: Remove unused declaration gve_rx_alloc_rings()

Message ID 20240816101906.882743-1-yuehaibing@huawei.com (mailing list archive)
State Accepted
Commit 359c5eb0f7364be9a26626402cc315e5e5f0d8c7
Delegated to: Netdev Maintainers
Headers show
Series [net-next] gve: Remove unused declaration gve_rx_alloc_rings() | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: ziweixiao@google.com
netdev/build_clang success Errors and warnings before: 16 this patch: 16
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 16 this patch: 16
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-08-16--21-00 (tests: 710)

Commit Message

Yue Haibing Aug. 16, 2024, 10:19 a.m. UTC
Commit f13697cc7a19 ("gve: Switch to config-aware queue allocation")
convert this function to gve_rx_alloc_rings_gqi().

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/google/gve/gve.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Horman Aug. 16, 2024, 4:45 p.m. UTC | #1
On Fri, Aug 16, 2024 at 06:19:06PM +0800, Yue Haibing wrote:
> Commit f13697cc7a19 ("gve: Switch to config-aware queue allocation")
> convert this function to gve_rx_alloc_rings_gqi().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>

In future, please consider grouping similar changes, say up to 10,
in a patchset.
Yue Haibing Aug. 17, 2024, 6:15 a.m. UTC | #2
On 2024/8/17 0:45, Simon Horman wrote:
> On Fri, Aug 16, 2024 at 06:19:06PM +0800, Yue Haibing wrote:
>> Commit f13697cc7a19 ("gve: Switch to config-aware queue allocation")
>> convert this function to gve_rx_alloc_rings_gqi().
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> 
> Reviewed-by: Simon Horman <horms@kernel.org>
> 
> In future, please consider grouping similar changes, say up to 10,
> in a patchset.

ok, thanks for your review.
> .
patchwork-bot+netdevbpf@kernel.org Aug. 20, 2024, 1 a.m. UTC | #3
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 16 Aug 2024 18:19:06 +0800 you wrote:
> Commit f13697cc7a19 ("gve: Switch to config-aware queue allocation")
> convert this function to gve_rx_alloc_rings_gqi().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  drivers/net/ethernet/google/gve/gve.h | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [net-next] gve: Remove unused declaration gve_rx_alloc_rings()
    https://git.kernel.org/netdev/net-next/c/359c5eb0f736

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h
index 09a85ed59143..301fa1ea4f51 100644
--- a/drivers/net/ethernet/google/gve/gve.h
+++ b/drivers/net/ethernet/google/gve/gve.h
@@ -1153,7 +1153,6 @@  int gve_rx_alloc_ring_gqi(struct gve_priv *priv,
 			  int idx);
 void gve_rx_free_ring_gqi(struct gve_priv *priv, struct gve_rx_ring *rx,
 			  struct gve_rx_alloc_rings_cfg *cfg);
-int gve_rx_alloc_rings(struct gve_priv *priv);
 int gve_rx_alloc_rings_gqi(struct gve_priv *priv,
 			   struct gve_rx_alloc_rings_cfg *cfg);
 void gve_rx_free_rings_gqi(struct gve_priv *priv,