diff mbox series

[net] netpoll: do not export netpoll_poll_[disable|enable]()

Message ID 20240820162053.3870927-1-edumazet@google.com (mailing list archive)
State Accepted
Commit 007d4271a5f10638cba6f0b99698557ef30014b9
Delegated to: Netdev Maintainers
Headers show
Series [net] netpoll: do not export netpoll_poll_[disable|enable]() | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present fail Series targets non-next tree, but doesn't contain any Fixes tags
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: leitao@debian.org
netdev/build_clang success Errors and warnings before: 16 this patch: 16
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 17 this patch: 17
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 14 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-08-20--18-00 (tests: 711)

Commit Message

Eric Dumazet Aug. 20, 2024, 4:20 p.m. UTC
netpoll_poll_disable() and netpoll_poll_enable() are only used
from core networking code, there is no need to export them.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/core/netpoll.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Simon Horman Aug. 21, 2024, 1:48 p.m. UTC | #1
On Tue, Aug 20, 2024 at 04:20:53PM +0000, Eric Dumazet wrote:
> netpoll_poll_disable() and netpoll_poll_enable() are only used
> from core networking code, there is no need to export them.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Aug. 22, 2024, 12:40 a.m. UTC | #2
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 20 Aug 2024 16:20:53 +0000 you wrote:
> netpoll_poll_disable() and netpoll_poll_enable() are only used
> from core networking code, there is no need to export them.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  net/core/netpoll.c | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - [net] netpoll: do not export netpoll_poll_[disable|enable]()
    https://git.kernel.org/netdev/net/c/007d4271a5f1

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index a58ea724790ce772004f4053afab0f7da458aff1..cff1f89719b6d6ba66b4687db03596d8362b6571 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -228,7 +228,6 @@  void netpoll_poll_disable(struct net_device *dev)
 		down(&ni->dev_lock);
 	srcu_read_unlock(&netpoll_srcu, idx);
 }
-EXPORT_SYMBOL(netpoll_poll_disable);
 
 void netpoll_poll_enable(struct net_device *dev)
 {
@@ -239,7 +238,6 @@  void netpoll_poll_enable(struct net_device *dev)
 		up(&ni->dev_lock);
 	rcu_read_unlock();
 }
-EXPORT_SYMBOL(netpoll_poll_enable);
 
 static void refill_skbs(void)
 {