| Message ID | 20240823070453.3327832-1-lihongbo22@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9ceebd7a264798a792a3cf515f4c331704d4c5fb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net/ipv4: fix macro definition sk_for_each_bound_bhash | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 23 Aug 2024 15:04:53 +0800 you wrote: > The macro sk_for_each_bound_bhash accepts a parameter > __sk, but it was not used, rather the sk2 is directly > used, so we replace the sk2 with __sk in macro. > > Signed-off-by: Hongbo Li <lihongbo22@huawei.com> > --- > net/ipv4/inet_connection_sock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net/ipv4: fix macro definition sk_for_each_bound_bhash https://git.kernel.org/netdev/net-next/c/9ceebd7a2647 You are awesome, thank you!
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index 64d07b842e73..ce4d77f49243 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -236,7 +236,7 @@ static bool inet_bhash2_conflict(const struct sock *sk, #define sk_for_each_bound_bhash(__sk, __tb2, __tb) \ hlist_for_each_entry(__tb2, &(__tb)->bhash2, bhash_node) \ - sk_for_each_bound(sk2, &(__tb2)->owners) + sk_for_each_bound((__sk), &(__tb2)->owners) /* This should be called only when the tb and tb2 hashbuckets' locks are held */ static int inet_csk_bind_conflict(const struct sock *sk,
The macro sk_for_each_bound_bhash accepts a parameter __sk, but it was not used, rather the sk2 is directly used, so we replace the sk2 with __sk in macro. Signed-off-by: Hongbo Li <lihongbo22@huawei.com> --- net/ipv4/inet_connection_sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)