diff mbox series

[net] net: ti: icssg-prueth: Fix 10M Link issue on AM64x

Message ID 20240823120412.1262536-1-danishanwar@ti.com (mailing list archive)
State Accepted
Commit e846be0fba85603d2ad6fc8db6810958d7b6bed1
Delegated to: Netdev Maintainers
Headers show
Series [net] net: ti: icssg-prueth: Fix 10M Link issue on AM64x | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 7 this patch: 7
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 7 this patch: 7
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 7 this patch: 7
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-08-25--21-00 (tests: 714)

Commit Message

MD Danish Anwar Aug. 23, 2024, 12:04 p.m. UTC 
Crash is seen on AM64x 10M link when connecting / disconnecting multiple
times.

The fix for this is to enable quirk_10m_link_issue for AM64x.

Fixes: b256e13378a9 ("net: ti: icssg-prueth: Add AM64x icssg support")
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
NOTE: If quirk_10m_link_issue is set, the ICSSG driver enables IEP1 which
fixes the 10M link issue.

As per Roger Quadros <rogerq@kernel.org> 's suggestion [1], posting this
as a separate patch.

[1] https://lore.kernel.org/all/cde0064d-83dd-4a7f-8921-053c25aae08b@kernel.org/

 drivers/net/ethernet/ti/icssg/icssg_prueth.c | 1 +
 1 file changed, 1 insertion(+)


base-commit: 82b8000c28b56b014ce52a1f1581bef4af148681

Comments

Roger Quadros Aug. 23, 2024, 3:49 p.m. UTC | #1 
On 23/08/2024 15:04, MD Danish Anwar wrote:
> Crash is seen on AM64x 10M link when connecting / disconnecting multiple
> times.
> 
> The fix for this is to enable quirk_10m_link_issue for AM64x.
> 
> Fixes: b256e13378a9 ("net: ti: icssg-prueth: Add AM64x icssg support")
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>
patchwork-bot+netdevbpf@kernel.org Aug. 27, 2024, 2:30 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 23 Aug 2024 17:34:12 +0530 you wrote:
> Crash is seen on AM64x 10M link when connecting / disconnecting multiple
> times.
> 
> The fix for this is to enable quirk_10m_link_issue for AM64x.
> 
> Fixes: b256e13378a9 ("net: ti: icssg-prueth: Add AM64x icssg support")
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> 
> [...]

Here is the summary with links:
  - [net] net: ti: icssg-prueth: Fix 10M Link issue on AM64x
    https://git.kernel.org/netdev/net/c/e846be0fba85

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 3e51b3a9b0a5..e3451beed323 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1452,6 +1452,7 @@  static const struct prueth_pdata am654_icssg_pdata = {
 
 static const struct prueth_pdata am64x_icssg_pdata = {
 	.fdqring_mode = K3_RINGACC_RING_MODE_RING,
+	.quirk_10m_link_issue = 1,
 	.switch_mode = 1,
 };