From patchwork Sat Aug 24 21:50:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maksym Kutsevol X-Patchwork-Id: 13776503 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EFAA29A1 for ; Sat, 24 Aug 2024 21:53:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724536428; cv=none; b=Pq1m6QD9mT1Bp9YsLRF4FgC/LAI87WTKnp9Ll1Ga6XY3S1bRIsazCMZoAqsRQdEbQvrrsj643+Qh264yiRmFZnqr4mSGeBdzcTAZ+WMcJkIQ3ERBbT2SuaI7rDMu4Ty0SzIJNgXe3Yl1UK8WlyYwx4SI7Fvp4emJdgq6jybwW8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724536428; c=relaxed/simple; bh=fdtk3j6B/K4q7tovpsSemG8d26oWj+UYPsItdJYC3gc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QZEashNFk6kV0nuhFLZ8RycxyX9pMGdxqGQduViEEdXnhVmsypDUiJF5YuwGBEiU+jYKztJK/h8mhC4yPJTxOM5F4vkcCHvwBkfzCEKI3ZhxX+2b2zeTywG9F4vFuW8z2u0BbroY2yyemmM5+ObWS3YhZdX4/GSHgZkpUrITQ8k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kutsevol.com; spf=none smtp.mailfrom=kutsevol.com; dkim=pass (2048-bit key) header.d=kutsevol-com.20230601.gappssmtp.com header.i=@kutsevol-com.20230601.gappssmtp.com header.b=X9wOQXgI; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kutsevol.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=kutsevol.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kutsevol-com.20230601.gappssmtp.com header.i=@kutsevol-com.20230601.gappssmtp.com header.b="X9wOQXgI" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7a337501630so208611385a.3 for ; Sat, 24 Aug 2024 14:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kutsevol-com.20230601.gappssmtp.com; s=20230601; t=1724536425; x=1725141225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=k/a//zUE8DB7atDLpLvSVe8EWN8ejgSw7SHzNNMS+z0=; b=X9wOQXgIyb7IdusKNU9hhPzNfDap5sijjiAbAtJ1P7KERbAYb4KjMknmAAR9aa2S7m IVMFlNw+oLKi9WZANf59QFsfKNNejUll8iHOZ0quNEtv0j75yflw8f0hDhAvb9tXgO/C DHD/9DfQRjrMKGh3yy2fcCooOFXBdZgqEATQ4aLEiU+1H1a0VQmq9zoZGfzzBs9neA9l ufdujvY/4snvvK53OlqONfwM5UxVekkaPY2TodRE0AVhEVcHl/vja2tml8zg3x8KtD8c GpMpDvckLcNGw9MDq7A6dzdJIcHxW8eLO0+rSRoakPNHAhxtOP2hNXRiZLfolmVH5jBs sUJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724536425; x=1725141225; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k/a//zUE8DB7atDLpLvSVe8EWN8ejgSw7SHzNNMS+z0=; b=cikyisbMbAHzPqsZSbNA0bKOUI1mICQNRtlTMsbKkGlgL6Q3fN8dOK6xyBY+RrHAtw sp5qPQzzs77hRLzMCXlLO1yhVk+MFMmiAZfbWGrJ23kO+hPSja33AK1vKFjymEMXQ+nr jDJiVjboXr577jSaa66BOel80WJTkAcGy9lR6pD4b2z/i4m2BfCGhEPGD2tbs+MUPfWw J8fH3qhEMU+RCviRiNFXvmbG2uclsVP9c37gTGAQeoMPDBPT7swaDimk6m4dr/6Skj4Q U0EDcQJDtDUNoyWrhzGbIWd6Ok1QstNgdaYuWC4bglEY1zSCHpKs7GTHiA75BqfXmUOR LNpQ== X-Gm-Message-State: AOJu0YyDqx34R5vhhWIYu+30o+ezugRbjIqgJoI/av47hFYBond+AuWM 0udtx2/Ebhu0DmjkgW9IjPmxuiC9NfRWbQzP1pn6cxaXs68KXaZuoP/dOzgZ3Bw= X-Google-Smtp-Source: AGHT+IGzJvpxizj5rbw73KGKfrizqiVQ48WAULMqVuTXPMQVzOBwNrvgkAAymySzOlv9q4M0xExPyQ== X-Received: by 2002:a05:620a:469e:b0:79f:148:d834 with SMTP id af79cd13be357-7a6897a71ffmr712460885a.59.1724536425193; Sat, 24 Aug 2024 14:53:45 -0700 (PDT) Received: from devbig254.ash8.facebook.com (fwdproxy-ash-114.fbsv.net. [2a03:2880:20ff:72::face:b00c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a67f3bb19esm307937385a.74.2024.08.24.14.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2024 14:53:44 -0700 (PDT) From: Maksym Kutsevol To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Breno Leitao , Maksym Kutsevol Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] netpoll: Make netpoll_send_udp return status instead of void Date: Sat, 24 Aug 2024 14:50:23 -0700 Message-ID: <20240824215130.2134153-1-max@kutsevol.com> X-Mailer: git-send-email 2.43.5 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org netpoll_send_udp can return if send was successful. It will allow client code to be aware of the send status. Possible return values are the result of __netpoll_send_skb (cast to int) and -ENOMEM. This doesn't cover the case when TX was not successful instantaneously and was scheduled for later, __netpoll__send_skb returns success in that case. Signed-off-by: Maksym Kutsevol --- Used in the next patch to expose send failure stats in netconsole include/linux/netpoll.h | 2 +- net/core/netpoll.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) base-commit: 8af174ea863c72f25ce31cee3baad8a301c0cf0f diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h index bd19c4b91e31..10ceef618e40 100644 --- a/include/linux/netpoll.h +++ b/include/linux/netpoll.h @@ -56,7 +56,7 @@ static inline void netpoll_poll_disable(struct net_device *dev) { return; } static inline void netpoll_poll_enable(struct net_device *dev) { return; } #endif -void netpoll_send_udp(struct netpoll *np, const char *msg, int len); +int netpoll_send_udp(struct netpoll *np, const char *msg, int len); void netpoll_print_options(struct netpoll *np); int netpoll_parse_options(struct netpoll *np, char *opt); int __netpoll_setup(struct netpoll *np, struct net_device *ndev); diff --git a/net/core/netpoll.c b/net/core/netpoll.c index d657b042d5a0..664343e3b688 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -395,7 +395,7 @@ netdev_tx_t netpoll_send_skb(struct netpoll *np, struct sk_buff *skb) } EXPORT_SYMBOL(netpoll_send_skb); -void netpoll_send_udp(struct netpoll *np, const char *msg, int len) +int netpoll_send_udp(struct netpoll *np, const char *msg, int len) { int total_len, ip_len, udp_len; struct sk_buff *skb; @@ -419,7 +419,7 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len) skb = find_skb(np, total_len + np->dev->needed_tailroom, total_len - len); if (!skb) - return; + return -ENOMEM; skb_copy_to_linear_data(skb, msg, len); skb_put(skb, len); @@ -495,7 +495,7 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len) skb->dev = np->dev; - netpoll_send_skb(np, skb); + return (int)netpoll_send_skb(np, skb); } EXPORT_SYMBOL(netpoll_send_udp);