| Message ID | 20240826032344.4012452-1-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [-next] MIPS: Remove obsoleted declaration for mv64340_irq_init | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Mon, Aug 26, 2024 at 11:23:44AM +0800, Gaosheng Cui wrote: > The mv64340_irq_init() have been removed since > commit 688b3d720820 ("[MIPS] Delete Ocelot 3 support."), and now > it is useless, so remove it. > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> Thanks, I agree that the mv64340_irq_init declaration is dangling since the cited commit. Reviewed-by: Simon Horman <horms@kernel.org>
On Mon, 26 Aug 2024 11:23:44 +0800 Gaosheng Cui wrote: > The mv64340_irq_init() have been removed since > commit 688b3d720820 ("[MIPS] Delete Ocelot 3 support."), and now > it is useless, so remove it. Most of the drivers which used this header have been deleted. Please move the only 3(?) defines that are actually used into arch/powerpc/platforms/chrp/pegasos_eth.c and delete the file completely.
On 2024/8/28 5:25, Jakub Kicinski wrote: > On Mon, 26 Aug 2024 11:23:44 +0800 Gaosheng Cui wrote: >> The mv64340_irq_init() have been removed since >> commit 688b3d720820 ("[MIPS] Delete Ocelot 3 support."), and now >> it is useless, so remove it. > Most of the drivers which used this header have been deleted. > Please move the only 3(?) defines that are actually used into > arch/powerpc/platforms/chrp/pegasos_eth.c > and delete the file completely. I hava re-sent a new patch v2 with this change, thanks.
diff --git a/include/linux/mv643xx.h b/include/linux/mv643xx.h index 000b126acfb6..a7975c16d13f 100644 --- a/include/linux/mv643xx.h +++ b/include/linux/mv643xx.h @@ -916,6 +916,4 @@ #define MV64340_SERIAL_INIT_CONTROL 0xf328 #define MV64340_SERIAL_INIT_STATUS 0xf32c -extern void mv64340_irq_init(unsigned int base); - #endif /* __ASM_MV643XX_H */
The mv64340_irq_init() have been removed since commit 688b3d720820 ("[MIPS] Delete Ocelot 3 support."), and now it is useless, so remove it. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- include/linux/mv643xx.h | 2 -- 1 file changed, 2 deletions(-)