| Message ID | 20240828123224.3697672-2-lihongbo22@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 68016b997222c9f866912f6911815105ed2ce473 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | replace deprecated strcpy with strscpy | expand |
diff --git a/net/core/dev.c b/net/core/dev.c index 0d0b983a6c21..b2ee944867e7 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -11121,7 +11121,7 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name, if (!dev->ethtool) goto free_all; - strcpy(dev->name, name); + strscpy(dev->name, name); dev->name_assign_type = name_assign_type; dev->group = INIT_NETDEV_GROUP; if (!dev->ethtool_ops)
The deprecated helper strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy() [1]. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] Signed-off-by: Hongbo Li <lihongbo22@huawei.com> --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)