From patchwork Wed Aug 28 12:32:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongbo Li X-Patchwork-Id: 13781226 X-Patchwork-Delegate: kuba@kernel.org Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0A8171E40; Wed, 28 Aug 2024 12:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724847874; cv=none; b=soTv3BElye9uGhRfNfhyd01EHtHyBaxxic6mYlvnKzaK5H67K3ntTfjYqfFtFoW80KfQSJ8kA8kv4EOoHzeR9zc9+u3ZHvSqwzqh1BYoUS4zvwwJ+NO91+F41HQF5eQkPN+r461y2hdYJ6DGxQTT5PrrnRh2YbGHMxiDBLtk/ks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724847874; c=relaxed/simple; bh=qYAFoQfx9FFxQ69I03wOJ1UUT/sKe3hcsz0+FUYZxSQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Gzu/1mBSIH74sfcm6c1IZswrsr9laWqBQ/90dmoKKCA6c0L5rYtnSuhbsTXxRKwEOBTzsQcqbAxd0SOLQVBIi7E0gKZW0qCIG2RjTIm79YMhoepZBomXyGlEymwdB9mRnkHZTykOsJGDwppqsi7fvd+jRE2tE40gh21nB0e1Zx0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Wv3Vl67jTzyRCW; Wed, 28 Aug 2024 20:23:59 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id 4734C180AE7; Wed, 28 Aug 2024 20:24:30 +0800 (CST) Received: from huawei.com (10.90.53.73) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 20:24:30 +0800 From: Hongbo Li To: , , , , , , , , CC: , , , Subject: [PATCH net-next v2 5/6] net/tipc: replace deprecated strcpy with strscpy Date: Wed, 28 Aug 2024 20:32:23 +0800 Message-ID: <20240828123224.3697672-6-lihongbo22@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240828123224.3697672-1-lihongbo22@huawei.com> References: <20240828123224.3697672-1-lihongbo22@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500022.china.huawei.com (7.185.36.66) X-Patchwork-Delegate: kuba@kernel.org The deprecated helper strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy() [1]. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] Signed-off-by: Hongbo Li --- net/tipc/bearer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 3c9e25f6a1d2..ae1ddbf71853 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c @@ -326,7 +326,7 @@ static int tipc_enable_bearer(struct net *net, const char *name, if (!b) return -ENOMEM; - strcpy(b->name, name); + strscpy(b->name, name); b->media = m; res = m->enable_media(net, b, attr); if (res) {