| Message ID | 20240830022025.610844-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2560db6ede1aaf162a73b2df43e0b6c5ed8819f7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v4] net: phy: Fix missing of_node_put() for leds | expand |
On Fri, Aug 30, 2024 at 10:20:25AM +0800, Jinjie Ruan wrote: > The call of of_get_child_by_name() will cause refcount incremented > for leds, if it succeeds, it should call of_node_put() to decrease > it, fix it. > > Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs") > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> To be 100% correct, it should have a CC: stable@vger.kernel.org https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#stable-tree But it will probably be O.K. with it missing. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 30 Aug 2024 10:20:25 +0800 you wrote: > The call of of_get_child_by_name() will cause refcount incremented > for leds, if it succeeds, it should call of_node_put() to decrease > it, fix it. > > Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs") > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > > [...] Here is the summary with links: - [net,v4] net: phy: Fix missing of_node_put() for leds https://git.kernel.org/netdev/net/c/2560db6ede1a You are awesome, thank you!
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 8f5314c1fecc..243dae686992 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -3424,11 +3424,13 @@ static int of_phy_leds(struct phy_device *phydev) err = of_phy_led(phydev, led); if (err) { of_node_put(led); + of_node_put(leds); phy_leds_unregister(phydev); return err; } } + of_node_put(leds); return 0; }
The call of of_get_child_by_name() will cause refcount incremented for leds, if it succeeds, it should call of_node_put() to decrease it, fix it. Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs") Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- v4: - Split out for net fix branch. - Signed-off-by: should always be last. v3: - Add Reviewed-by. v2: - Split into 2 patches. - Use of_node_put() rather than __free() to fix it. --- drivers/net/phy/phy_device.c | 2 ++ 1 file changed, 2 insertions(+)