| Message ID | 20240903-octeontx2-sparse-v1-1-f190309ecb0a@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | octeontx2: Address some Sparse warnings | expand |
>-----Original Message----- >From: Simon Horman <horms@kernel.org> >Sent: Tuesday, September 3, 2024 9:57 PM >To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Linu Cherian ><lcherian@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>; >Jerin Jacob <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; >Subbaraya Sundeep Bhatta <sbhatta@marvell.com> >Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet ><edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni ><pabeni@redhat.com>; Nathan Chancellor <nathan@kernel.org>; Nick >Desaulniers <ndesaulniers@google.com>; Bill Wendling ><morbo@google.com>; Justin Stitt <justinstitt@google.com>; >netdev@vger.kernel.org; llvm@lists.linux.dev >Subject: [EXTERNAL] [PATCH net-next 1/2] octeontx2-af: Pass string literal as >format argument of alloc_workqueue() >Recently I noticed that both gcc-14 and clang-18 report that passing a non- >string literal as the format argument of alloc_workqueue() is potentially >insecure. > >E.g. clang-18 says: > >.../rvu.c:2493:32: warning: format string is not a string literal (potentially >insecure) [-Wformat-security] > 2493 | mw->mbox_wq = alloc_workqueue(name, > | ^~~~ >.../rvu.c:2493:32: note: treat the string as an argument to avoid this > 2493 | mw->mbox_wq = alloc_workqueue(name, > | ^ > | "%s", > >It is always the case where the contents of name is safe to pass as the format >argument. That is, in my understanding, it never contains any format escape >sequences. > >But, it seems better to be safe than sorry. And, as a bonus, compiler output >becomes less verbose by addressing this issue as suggested by clang-18. > >Compile tested only. > >Signed-off-by: Simon Horman <horms@kernel.org> >--- > drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c >b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c >index ac7ee3f3598c..1a97fb9032fa 100644 >--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c >+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c >@@ -2479,9 +2479,9 @@ static int rvu_mbox_init(struct rvu *rvu, struct >mbox_wq_info *mw, > goto free_regions; > } > >- mw->mbox_wq = alloc_workqueue(name, >+ mw->mbox_wq = alloc_workqueue("%s", > WQ_UNBOUND | WQ_HIGHPRI | >WQ_MEM_RECLAIM, >- num); >+ num, name); > if (!mw->mbox_wq) { > err = -ENOMEM; > goto unmap_regions; > >-- >2.45.2 Tested-by: Geetha sowjanya <gakula@marvell.com>
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c index ac7ee3f3598c..1a97fb9032fa 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c @@ -2479,9 +2479,9 @@ static int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw, goto free_regions; } - mw->mbox_wq = alloc_workqueue(name, + mw->mbox_wq = alloc_workqueue("%s", WQ_UNBOUND | WQ_HIGHPRI | WQ_MEM_RECLAIM, - num); + num, name); if (!mw->mbox_wq) { err = -ENOMEM; goto unmap_regions;
Recently I noticed that both gcc-14 and clang-18 report that passing a non-string literal as the format argument of alloc_workqueue() is potentially insecure. E.g. clang-18 says: .../rvu.c:2493:32: warning: format string is not a string literal (potentially insecure) [-Wformat-security] 2493 | mw->mbox_wq = alloc_workqueue(name, | ^~~~ .../rvu.c:2493:32: note: treat the string as an argument to avoid this 2493 | mw->mbox_wq = alloc_workqueue(name, | ^ | "%s", It is always the case where the contents of name is safe to pass as the format argument. That is, in my understanding, it never contains any format escape sequences. But, it seems better to be safe than sorry. And, as a bonus, compiler output becomes less verbose by addressing this issue as suggested by clang-18. Compile tested only. Signed-off-by: Simon Horman <horms@kernel.org> --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)