| Message ID | 20240903030303.494089-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ptp: ptp_idt82p33: Convert comma to semicolon | expand |
On Tue, Sep 03, 2024 at 11:03:02AM +0800, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. Thanks, It might be nice to add a bit more text here. Describing the motivation for the change and how the problem was found. E.g. Replace comma between expressions with semicolons. Using a ',' in place of a ';' can have unintended side effects. Although that is not the case here, it is seems best to use ';' unless ',' is intended. Found by inspection. No functional change intended. Compile tested only. > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/ptp/ptp_idt82p33.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c > index 92bb42c43fb2..d5732490ed9d 100644 > --- a/drivers/ptp/ptp_idt82p33.c > +++ b/drivers/ptp/ptp_idt82p33.c > @@ -1171,10 +1171,10 @@ static void idt82p33_caps_init(u32 index, struct ptp_clock_info *caps, > caps->owner = THIS_MODULE; > caps->max_adj = DCO_MAX_PPB; > caps->n_per_out = MAX_PER_OUT; > - caps->n_ext_ts = MAX_PHC_PLL, > - caps->n_pins = max_pins, > - caps->adjphase = idt82p33_adjwritephase, > - caps->getmaxphase = idt82p33_getmaxphase, > + caps->n_ext_ts = MAX_PHC_PLL; > + caps->n_pins = max_pins; > + caps->adjphase = idt82p33_adjwritephase; > + caps->getmaxphase = idt82p33_getmaxphase; > caps->adjfine = idt82p33_adjfine; > caps->adjtime = idt82p33_adjtime; > caps->gettime64 = idt82p33_gettime; > -- > 2.25.1 > >
diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c index 92bb42c43fb2..d5732490ed9d 100644 --- a/drivers/ptp/ptp_idt82p33.c +++ b/drivers/ptp/ptp_idt82p33.c @@ -1171,10 +1171,10 @@ static void idt82p33_caps_init(u32 index, struct ptp_clock_info *caps, caps->owner = THIS_MODULE; caps->max_adj = DCO_MAX_PPB; caps->n_per_out = MAX_PER_OUT; - caps->n_ext_ts = MAX_PHC_PLL, - caps->n_pins = max_pins, - caps->adjphase = idt82p33_adjwritephase, - caps->getmaxphase = idt82p33_getmaxphase, + caps->n_ext_ts = MAX_PHC_PLL; + caps->n_pins = max_pins; + caps->adjphase = idt82p33_adjwritephase; + caps->getmaxphase = idt82p33_getmaxphase; caps->adjfine = idt82p33_adjfine; caps->adjtime = idt82p33_adjtime; caps->gettime64 = idt82p33_gettime;
Replace a comma between expression statements by a semicolon. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/ptp/ptp_idt82p33.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)