| Message ID | 20240903095111.7204-1-liujing@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests/net: do_setcpu function not need to have a return value | expand |
On Tue, Sep 03, 2024 at 05:51:11PM +0800, Liu Jing wrote: > in the do_setcpu, this function does not need to have a return value, > which is meaningless > > Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com> Thanks, I also see that the caller does not check the return value. Reviewed-by: Simon Horman <horms@kernel.org>
On Tue, 3 Sep 2024 17:51:11 +0800 Liu Jing wrote: > in the do_setcpu, this function does not need to have a return value, > which is meaningless This test is flaky: https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=msg-zerocopy-sh Could you please try to figure out what the problem is and fix it instead of sending "cleanups"?
diff --git a/tools/testing/selftests/net/msg_zerocopy.c b/tools/testing/selftests/net/msg_zerocopy.c index bdc03a2097e8..0b54f2011449 100644 --- a/tools/testing/selftests/net/msg_zerocopy.c +++ b/tools/testing/selftests/net/msg_zerocopy.c @@ -118,7 +118,7 @@ static uint16_t get_ip_csum(const uint16_t *start, int num_words) return ~sum; } -static int do_setcpu(int cpu) +static void do_setcpu(int cpu) { cpu_set_t mask; @@ -129,7 +129,6 @@ static int do_setcpu(int cpu) else if (cfg_verbose) fprintf(stderr, "cpu: %u\n", cpu); - return 0; } static void do_setsockopt(int fd, int level, int optname, int val)
in the do_setcpu, this function does not need to have a return value, which is meaningless Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com> --- tools/testing/selftests/net/msg_zerocopy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)