From patchwork Wed Sep 4 18:29:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 13791265 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEFB412BEBB; Wed, 4 Sep 2024 18:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725474599; cv=none; b=NxButpzbdi8wDtEfI8OFKAgWqKC/PJxAk4mPEcVNDhRfoG4ePu/xcTQ8SYr1Z2vn+WsZcaj6i4cZePM5PaUQmipYWsjZIvYHflg+0/w+Evdal8bYg4Rb8sPVkSJyVXkwJvzV4XEvRNwgm7Z/sSo3pWVNEVgSuEcnsJyp/Rnflns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725474599; c=relaxed/simple; bh=kL2piebXo3Utwe8dYmGRPzr5ytc0xKTfFdXVyjAqo6o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ULjNyO4NrlEJp+YZ0ZPWyxdwSP2zh0WiCpSXiHETkLI44RDVjeKkQ51Es3CW+3vxooEZySHK4rwlAZ1qlE/JBKUgclr3jI5COTMn4XeLEeTIorXFdzaAlMZ1oQVR8Ly2AjVum7tfi0r5+TB9LqCS9cioTovs1TYbgzX2Dy8dWiM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kYg2gO63; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kYg2gO63" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6B6BC4CECA; Wed, 4 Sep 2024 18:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725474598; bh=kL2piebXo3Utwe8dYmGRPzr5ytc0xKTfFdXVyjAqo6o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kYg2gO633yhhL+8/dd5qudGjjrkbDA3DZNy+WoleukpLrlb4Slmq2QsMCCYTMweP2 PNtQnWD3yZjb3pyzJPBZw4yv2T3ZAinWclUBLaVpBarehbG3CpkU/Va+JVgLo3DTFx V0We/pS5IgQnuCFRnMBg7hlz7tyDzKYNBjS0qwq4CHaRMqVVfJLqSw0BOAAEkFrFGK 0Rma1VABzYAanh2PI3TD71J7h2JFjHfI3eMAsFvDnhYjvZYUPuvW5QcfxntOvExXBK Mkz7x2m7NwD9DEZjRMNIc03YiE53v0PC3C7ki2vyXd6holu5LzQbwwEqmfIADay8IL JNeM9szfb+g1w== From: Simon Horman Date: Wed, 04 Sep 2024 19:29:37 +0100 Subject: [PATCH net-next v2 2/2] octeontx2-pf: Make iplen __be16 in otx2_sqe_add_ext() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240904-octeontx2-sparse-v2-2-14f2305fe4b2@kernel.org> References: <20240904-octeontx2-sparse-v2-0-14f2305fe4b2@kernel.org> In-Reply-To: <20240904-octeontx2-sparse-v2-0-14f2305fe4b2@kernel.org> To: Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , Hariprasad Kelam , Subbaraya Sundeep Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, llvm@lists.linux.dev X-Mailer: b4 0.14.0 X-Patchwork-Delegate: kuba@kernel.org In otx2_sqe_add_ext() iplen is used to hold a 16-bit big-endian value, but it's type is u16, indicating a host byte order integer. Address this mismatch by changing the type of iplen to __be16. Flagged by Sparse as: .../otx2_txrx.c:699:31: warning: incorrect type in assignment (different base types) .../otx2_txrx.c:699:31: expected unsigned short [usertype] iplen .../otx2_txrx.c:699:31: got restricted __be16 [usertype] .../otx2_txrx.c:701:54: warning: incorrect type in assignment (different base types) .../otx2_txrx.c:701:54: expected restricted __be16 [usertype] tot_len .../otx2_txrx.c:701:54: got unsigned short [usertype] iplen .../otx2_txrx.c:704:60: warning: incorrect type in assignment (different base types) .../otx2_txrx.c:704:60: expected restricted __be16 [usertype] payload_len .../otx2_txrx.c:704:60: got unsigned short [usertype] iplen Introduced in commit dc1a9bf2c816 ("octeontx2-pf: Add UDP segmentation offload support") No functional change intended. Compile tested only by author. Tested-by: Geetha sowjanya Signed-off-by: Simon Horman --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c index 3eb85949677a..933e18ba2fb2 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c @@ -687,7 +687,7 @@ static void otx2_sqe_add_ext(struct otx2_nic *pfvf, struct otx2_snd_queue *sq, } else if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4) { __be16 l3_proto = vlan_get_protocol(skb); struct udphdr *udph = udp_hdr(skb); - u16 iplen; + __be16 iplen; ext->lso_sb = skb_transport_offset(skb) + sizeof(struct udphdr);