| Message ID | 20240904093243.3345012-4-lihongbo22@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8b51455bbd45e1b2d6980536698be4f4f332b385 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | make use of the helper macro LIST_HEAD() | expand |
On Wed, Sep 04, 2024 at 05:32:41PM +0800, Hongbo Li wrote: > list_head can be initialized automatically with LIST_HEAD() > instead of calling INIT_LIST_HEAD(). Here we can simplify > the code. > > Signed-off-by: Hongbo Li <lihongbo22@huawei.com> Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
diff --git a/net/netfilter/core.c b/net/netfilter/core.c index b00fc285b334..b9f551f02c81 100644 --- a/net/netfilter/core.c +++ b/net/netfilter/core.c @@ -655,11 +655,9 @@ void nf_hook_slow_list(struct list_head *head, struct nf_hook_state *state, const struct nf_hook_entries *e) { struct sk_buff *skb, *next; - struct list_head sublist; + LIST_HEAD(sublist); int ret; - INIT_LIST_HEAD(&sublist); - list_for_each_entry_safe(skb, next, head, list) { skb_list_del_init(skb); ret = nf_hook_slow(skb, state, e, 0);
list_head can be initialized automatically with LIST_HEAD() instead of calling INIT_LIST_HEAD(). Here we can simplify the code. Signed-off-by: Hongbo Li <lihongbo22@huawei.com> --- v2: - Keep the reverse xmas tree order as Pablo's suggested. v1: https://lore.kernel.org/netdev/20240827165723.GQ1368797@kernel.org/T/#ma8c13d915dce14e01b66c03fd7c2588344596ac8 --- net/netfilter/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)